From: Paul Allen <allenp@nwlink.com>
To: linux-kernel@vger.kernel.org
Subject: Ext2 zeros inode in directory entry when deleting files.
Date: Sat, 16 Mar 2002 00:24:15 -0800 [thread overview]
Message-ID: <3C93012F.9080601@nwlink.com> (raw)
While helping a friend recover from a catastrophic "rm -rf" accident,
I discovered that deleted files have the inode number in their old
directory entries zeroed. This makes it impossible to match file
names with recovered files. I've verified this behavior on Mandrake
8.1 with Mandrake's stock 2.4.8 kernel. In my kernel sources and
in the stock 2.4.8 sources, the function ext2_delete_entry() in
fs/ext2/dir.c has this line:
dir->inode = 0;
I've done some searching with Google for discussion of this feature.
I didn't find any, but I did find a patch that appears to have
introduced the above line and an "annotated" listing of dir.c
suggesting that the line is part of revision 1.2. The patch that
apparently introduced this line looks like it was part of a major
overhaul.
Now, I'm tempted to comment the line out in my kernel and see
what happens. But it does occur to me that hackers with more
experience than I may zeroing the inode number for a reason and
may be depending on it elsewhere in the kernel. Or perhaps the
ext2 flavor of fsck will malfunction if deleted directory entries
have a non-zero inode?
Can anybody suggest a reason for the existence of the above line
in fs/ext2/dir.c? Or possibly suggest what would certainly break
if I removed it in my kernel?
Thanks!
Paul Allen
allenp@nwlink.com
next reply other threads:[~2002-03-16 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-16 8:24 Paul Allen [this message]
2002-03-16 9:02 ` Ext2 zeros inode in directory entry when deleting files Alexander Viro
2002-03-17 7:25 ` tytso
2002-03-17 17:21 ` Oliver Xymoron
2002-03-17 18:17 ` Mark Mielke
2002-03-17 21:20 ` Oliver Xymoron
2002-03-17 23:53 ` Mark Mielke
2002-03-19 0:50 ` Paul Allen
2002-03-19 1:34 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C93012F.9080601@nwlink.com \
--to=allenp@nwlink.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox