Re: [PATCH] devexit fixes in i82092.c

Arjan van de Ven
2002-03-16T09:41:23Z

On Fri, Mar 15, 2002 at 11:40:30PM -0800, Linus Torvalds wrote:
>
> On Fri, 15 Mar 2002, Jeff Garzik wrote:
> >
> > I wonder if mochel already code for this, or has thought about this...
> > Just like suspend, IMO we ideally should use the device tree to
> > shutdown the system, agreed?
>
> Ideally we should, yes. Although if we really turn off power, it doesn't
> much matter.

It kind of does for warm reboots. I'm getting more and more reports that
on warm reboot, the bios then can't boot again because we left some
hardware (usually the scsi or ide controller) in a state the bios didn't expect.
While I consider it a bios duty to reset the hw, using the device-tree for
clean shutdown of hardware at least would allow us to make it work.

> This is what I want. Those reboot/shutdown notifiers are completely and
> utterly buggy, and cannot sanely handle any kind of device hierarchy.

Device owned notifiers could indeed go; the question is if
non-device owned ones (the only purpose of those would
probably cluster filesystems) should make a "fake" device or
keep using the current mechanism.

Greetings,
Arjan van de Ven