From: Paul Gortmaker <p_gortmaker@yahoo.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] no verify_write when CONFIG_WP_WORKS_OK=y
Date: Sun, 17 Mar 2002 07:51:19 -0500 [thread overview]
Message-ID: <3C948C97.719B9FF0@yahoo.com> (raw)
Linus Torvalds wrote:
> Note that the i386 has _long_ been a "stepchild", though: because of the
> lack of WP, the kernel simply doesn't do threaded MM correctly on a 386.
That reminds me of a patch to gut verify_write when CONFIG_X86_WP_WORKS_OK=y.
Saves a few bytes. Patch is against 2.5.7pre2.
We could bin the whole thing and stop exporting it, but there may be users
who try to load binary only modules that were built for 386 and hence expect
verify_write to be exported regardless of CPU type the kernel was built for.
Paul.
--- ../linux/arch/i386/mm/fault.c Sun Mar 17 07:14:09 2002
+++ arch/i386/mm/fault.c Sun Mar 17 07:02:21 2002
@@ -4,6 +4,7 @@
* Copyright (C) 1995 Linus Torvalds
*/
+#include <linux/config.h>
#include <linux/signal.h>
#include <linux/sched.h>
#include <linux/kernel.h>
@@ -29,6 +30,9 @@
extern int console_loglevel;
+#ifdef CONFIG_X86_WP_WORKS_OK
+int __verify_write(const void * addr, unsigned long size) {return 1;}
+#else
/*
* Ugly, ugly, but the goto's result in better assembly..
*/
@@ -93,6 +97,7 @@
}
goto bad_area;
}
+#endif
extern spinlock_t timerlist_lock;
reply other threads:[~2002-03-17 13:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C948C97.719B9FF0@yahoo.com \
--to=p_gortmaker@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox