From: Andrew Morton <akpm@zip.com.au>
To: lkml <linux-kernel@vger.kernel.org>
Subject: aa-170-drain_cpu_caches
Date: Tue, 19 Mar 2002 20:01:54 -0800 [thread overview]
Message-ID: <3C9809B2.BDBB9401@zip.com.au> (raw)
A performance tweak (I guess): perform the cross-CPU cache reclaim
operation outside the global semaphore. Needs more explanation.
=====================================
--- 2.4.19-pre3/mm/slab.c~aa-170-drain_cpu_caches Tue Mar 19 19:49:03 2002
+++ 2.4.19-pre3-akpm/mm/slab.c Tue Mar 19 19:49:03 2002
@@ -916,8 +916,6 @@ static int __kmem_cache_shrink(kmem_cach
slab_t *slabp;
int ret;
- drain_cpu_caches(cachep);
-
spin_lock_irq(&cachep->spinlock);
/* If the cache is growing, stop shrinking. */
@@ -987,6 +985,8 @@ int kmem_cache_destroy (kmem_cache_t * c
kmem_cache_t, next);
list_del(&cachep->next);
up(&cache_chain_sem);
+
+ drain_cpu_caches(cachep);
if (__kmem_cache_shrink(cachep)) {
printk(KERN_ERR "kmem_cache_destroy: Can't free all objects %p\n",
-
reply other threads:[~2002-03-20 4:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C9809B2.BDBB9401@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox