From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Axel Kittenberger <Axel.Kittenberger@maxxio.at>
Cc: linux-kernel@vger.kernel.org, Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: Patch, forward release() return values to the close() call
Date: Thu, 21 Mar 2002 03:27:40 -0500 [thread overview]
Message-ID: <3C99997C.6030202@mandrakesoft.com> (raw)
In-Reply-To: <200203210747.IAA25949@merlin.gams.co.at>
Whoops, my apologies. The patch looks ok to me.
I read your text closely and the patch not close enough. As I said, it
is indeed wrong for a device driver to fail f_op->release(), "fail"
being defined as leaving fd state lying around, assuming that the system
will fail the fput().
But your patch merely propagates a return value, not change behavior,
which seems sane to me.
Jeff
next prev parent reply other threads:[~2002-03-21 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-21 7:47 Patch, forward release() return values to the close() call Axel Kittenberger
2002-03-21 8:13 ` Jeff Garzik
2002-03-21 16:32 ` David Brown
2002-03-22 7:58 ` Axel Kittenberger
2002-03-22 13:51 ` David Brown
2002-03-25 9:50 ` Axel Kittenberger
2002-03-25 13:33 ` David Brown
2002-03-26 8:52 ` Axel Kittenberger
2002-03-21 8:21 ` Jeff Garzik
2002-03-21 8:27 ` Jeff Garzik [this message]
2002-03-21 9:10 ` Oliver Neukum
2002-03-21 9:18 ` Jeff Garzik
2002-03-21 10:14 ` Oliver.Neukum
[not found] <mailman.1016697001.29134.linux-kernel2news@redhat.com>
[not found] ` <200203211845.g2LIjTu22218@devserv.devel.redhat.com>
2002-03-22 8:06 ` Axel Kittenberger
2002-03-22 8:53 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C99997C.6030202@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=Axel.Kittenberger@maxxio.at \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox