Re: [patch] smaller kernels

[Andrew Morton <akpm@zip.com.au>]

Rusty Russell wrote:
> 
> On Tue, 19 Mar 2002 22:11:48 -0800
> Andrew Morton <akpm@zip.com.au> wrote:
> 
> > This is the result of a search-and-destroy mission against
> > oft-repeated strings in the kernel text.  These come about
> > due to the toolchain's inability to common up strings between
> > compilation units.
> 
> The name is horrible.  BUG() stands out: perhaps "BUG_LITE()"?

out_of_line_bug()? It's a bit ornate I guess, but it tells
you what it does when you look at it.

> And I'm not sure DaveM'll appreciate this:
> 
> >  static inline char *__skb_pull(struct sk_buff *skb, unsigned int len)
> >  {
> >       skb->len-=len;
> > -     if (skb->len < skb->data_len)
> > -             BUG();
> >       return  skb->data+=len;
> >  }

OK, we can out that back (out-of-line) for -pre6.

-