From: "Ulrich Windl" <Ulrich.Windl@rz.uni-regensburg.de>
To: Paul Gortmaker <p_gortmaker@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.19 do_adjtimex parameter checking
Date: Mon, 25 Mar 2002 08:45:04 +0100 [thread overview]
Message-ID: <3C9EE38F.5986.2DAB75@localhost> (raw)
In-Reply-To: <3C9DA6F9.1CD32F3D@yahoo.com>
On 24 Mar 2002, at 5:14, Paul Gortmaker wrote:
> Okay then, the bug still stands, but you want a different fix really.
> The user that reported it to me was infact setting multiple bit
> combos, which you indicate as taboo (but currently allowed). So
> when multiple bit combos are given, we can either do:
>
> a) return -EINVAL if more than ADJ_OFFSET_SINGLESHOT is set
> b) clear/ignore any bits above and beyond ADJ_OFFSET_SINGLESHOT.
>
> As you are a time guru, please indicate which is preferable and I will
> bounce Rusty an appropriate patch.
Thanks for the flowers,
my preference is EINVAL of course. Silently adjusting parameters is bad
IMHO.
Regards,
Ulrich
prev parent reply other threads:[~2002-03-25 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3C99E2E2.30DCCF46@yahoo.com>
2002-03-21 15:22 ` [PATCH] 2.4.19 do_adjtimex parameter checking Ulrich Windl
2002-03-24 10:14 ` Paul Gortmaker
2002-03-25 7:45 ` Ulrich Windl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C9EE38F.5986.2DAB75@localhost \
--to=ulrich.windl@rz.uni-regensburg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox