From: Andrew Morton <akpm@zip.com.au>
To: Alexander Viro <viro@math.psu.edu>
Cc: "David S. Miller" <davem@redhat.com>,
tim@birdsnest.maths.tcd.ie, linux-kernel@vger.kernel.org
Subject: Re: linux-2.5.7
Date: Sun, 31 Mar 2002 00:30:21 -0800 [thread overview]
Message-ID: <3CA6C91D.67186FAB@zip.com.au> (raw)
In-Reply-To: <20020330.182243.88963096.davem@redhat.com> <Pine.GSO.4.21.0203310253360.4431-100000@weyl.math.psu.edu>
Alexander Viro wrote:
>
> ...
> +/*
> + * "Conditional" syscalls
> + *
> + * What we want is __attribute__((weak,alias("sys_ni_syscall"))),
> + * but it doesn't work on sparc64, so we just do it by hand
> + */
> +#define cond_syscall(x) asm(".weak\t" #x "\n\t.set\t" #x ",sys_ni_syscall");
> +
> +cond_syscall(sys_nfsservctl)
> +cond_syscall(sys_quotactl)
> +cond_syscall(sys_acct)
> +
Could you remind us what problem this is solving? The
#ifdef approach seemed reasonable and there's no indication
here why weak linkage is needed.
Weak linkage could perhaps be useful elsewhere. Maybe this
should be implemented as
weak_symbol(sym, default_sym)
in some generic header somewhere...
-
next prev parent reply other threads:[~2002-03-31 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-30 23:23 linux-2.5.7 Timothy Murphy
2002-03-30 23:41 ` linux-2.5.7 Alexander Viro
2002-03-31 2:22 ` linux-2.5.7 David S. Miller
2002-03-31 7:54 ` linux-2.5.7 Alexander Viro
2002-03-31 8:30 ` Andrew Morton [this message]
2002-03-31 8:42 ` linux-2.5.7 Alexander Viro
2002-04-04 9:42 ` linux-2.5.7 Richard Henderson
2002-04-04 14:45 ` linux-2.5.7 Alvaro Figueroa
2002-03-31 3:25 ` linux-2.5.7 Pierre Rousselet
2002-03-31 6:21 ` linux-2.5.7 David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2002-03-30 23:48 linux-2.5.7 Neil Brown
2002-03-31 0:02 ` linux-2.5.7 Keith Owens
2002-03-31 2:04 ` linux-2.5.7 Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CA6C91D.67186FAB@zip.com.au \
--to=akpm@zip.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@birdsnest.maths.tcd.ie \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox