public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Graham Cobb <g+linux@cobb.uk.net>
To: linux-kernel@vger.kernel.org
Cc: marcelo@conectiva.com.br, mj@ucw.cz
Subject: [PATCH] PCI fixup for old NCR 53C810 SCSI chips, kernel 2.4.18
Date: Mon, 01 Apr 2002 01:02:07 +0100	[thread overview]
Message-ID: <3CA7A37F.3060600@cobb.uk.net> (raw)

This patch fixes a problem which prevents any version of the 2.4 kernel 
running on DECpc XL systems (from c. 1993).  On that system, the NCR 
53C810 SCSI subsystem integrated on the motherboard does not have a PCI 
class code, which breaks PCI resource allocation in all 2.4 kernels. 
 The symptom is "resource collisions" reported for the SCSI device:

PCI: Device 00:01.0 not available because of resource collisions

These systems typically only have SCSI disks so the 2.4 kernel cannot be 
booted.

If you are running an earlier kernel and want to know if you will have 
this problem when upgrading, use lspci -vvv and look for output similar 
to this:

00:01.0 Non-VGA unclassified device: Symbios Logic Inc. (formerly NCR) 
53c810 (rev 01)
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- 
Stepping- SERR- FastB2B-
    Status: Cap- 66Mhz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- 
<TAbort- <MAbort- >SERR- <PERR-
    Latency: 4 set
    Interrupt: pin A routed to IRQ 11
    Region 0: I/O ports at d000

If the listing says "Non-VGA unclassified device" for the 53c810, it 
will not work with the 2.4 kernel.

The workround is to add fixup code for this device in 
arch/i386/kernel/pci-pc.c.  The patch is small and is included below.  I 
would appreciate anyone who uses NCR 53c810-based SCSI devices testing 
this patch to make sure it doesn't break any other configurations.
Graham Cobb

--- linux-2.4.18.orig/arch/i386/kernel/pci-pc.c    Mon Feb 25 19:37:53 2002
+++ linux-2.4.18/arch/i386/kernel/pci-pc.c    Sun Mar 31 23:29:30 2002
@@ -1058,6 +1058,18 @@
         d->resource[i].flags |= PCI_BASE_ADDRESS_SPACE_IO;
 }
 
+static void __devinit  pci_fixup_ncr53c810(struct pci_dev *d)
+{
+    /*
+     * NCR 53C810 returns class code 0 (at least on some systems).
+     * Fix class to be PCI_CLASS_STORAGE_SCSI
+     */
+    if (!d->class) {
+        printk("PCI: fixing NCR 53C810 class code for %s\n", d->slot_name);
+        d->class = PCI_CLASS_STORAGE_SCSI << 8;
+    }
+}
+
 static void __devinit pci_fixup_ide_bases(struct pci_dev *d)
 {
     int i;
@@ -1148,6 +1160,7 @@
     { PCI_FIXUP_HEADER,    PCI_VENDOR_ID_VIA,    
PCI_DEVICE_ID_VIA_8622,            pci_fixup_via_northbridge_bug },
     { PCI_FIXUP_HEADER,    PCI_VENDOR_ID_VIA,    
PCI_DEVICE_ID_VIA_8361,            pci_fixup_via_northbridge_bug },
     { PCI_FIXUP_HEADER,    PCI_VENDOR_ID_VIA,    
PCI_DEVICE_ID_VIA_8367_0,    pci_fixup_via_northbridge_bug },
+    { PCI_FIXUP_HEADER,    PCI_VENDOR_ID_NCR,    
PCI_DEVICE_ID_NCR_53C810,    pci_fixup_ncr53c810 },
     { 0 }
 };
 



             reply	other threads:[~2002-04-01  0:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-01  0:02 Graham Cobb [this message]
2002-04-01 14:51 ` [PATCH] PCI fixup for old NCR 53C810 SCSI chips, kernel 2.4.18 Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CA7A37F.3060600@cobb.uk.net \
    --to=g+linux@cobb.uk.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=mj@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox