From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Denny Gudea <ekay@ecs.fullerton.edu>
Cc: andrewm@uow.edu.au, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: 3c59x.c - kernel message explosion (fwd)
Date: Wed, 03 Apr 2002 18:49:44 -0500 [thread overview]
Message-ID: <3CAB9518.5090409@mandrakesoft.com> (raw)
In-Reply-To: <Pine.GSO.4.33.0204031538340.19587-100000@titan.ecs.fullerton.edu>
Denny Gudea wrote:
> i believe the problem resides when it tests for the debug level:
>
> if (vortex_debug > 2
> || (tx_status != 0x88 && vortex_debug > 0)) {
>
> the || operator should be a && because we only want to print the error
> message if debug is greater than 2 and the transmit status is not what it
> should be.
the test looks ok... it prints if the status is not what it should be,
if vortex_debug is 1 or 2, and unconditionally prints the status if
vortex_debug is 3 or greater.
What is your vortex_debug setting?
Jeff
next prev parent reply other threads:[~2002-04-03 23:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-03 23:39 3c59x.c - kernel message explosion (fwd) Denny Gudea
2002-04-03 23:49 ` Jeff Garzik [this message]
2002-04-04 0:08 ` Denny Gudea
2002-04-03 23:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CAB9518.5090409@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=andrewm@uow.edu.au \
--cc=ekay@ecs.fullerton.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox