public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: flaniganr@intel.co.jp
Cc: linux-kernel@vger.kernel.org, jt@hpl.hp.com, dhinds@zen.stanford.edu
Subject: Re: [PATCH] 2.5.8-pre1 wavelan_cs
Date: Thu, 04 Apr 2002 02:18:45 -0500	[thread overview]
Message-ID: <3CABFE55.9@mandrakesoft.com> (raw)
In-Reply-To: <87vgb8x8bt.fsf@hazuki.jp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

flaniganr@intel.co.jp wrote:
> not sure if i did this right, so if you 
> have any suggestions/comments please tell me.
> 
> Basically 2.5.8-pre1 fails to compile with:
> 
> In file included from wavelan_cs.c:59:
> wavelan_cs.p.h:495:33: warning: extra tokens at end of #undef directive
> wavelan_cs.c: In function `wv_pcmcia_config':
> wavelan_cs.c:4480: structure has no member named `rmem_start'
> wavelan_cs.c:4482: structure has no member named `rmem_end'
> make[3]: *** [wavelan_cs.o] Error 1

not needed, just delete the unused references to rmem_{start,end}.
(see attached patch)

	Jeff




[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 606 bytes --]

diff -Nru a/drivers/net/wireless/wavelan_cs.c b/drivers/net/wireless/wavelan_cs.c
--- a/drivers/net/wireless/wavelan_cs.c	Thu Apr  4 02:17:38 2002
+++ b/drivers/net/wireless/wavelan_cs.c	Thu Apr  4 02:17:38 2002
@@ -4477,9 +4477,8 @@
 	  break;
 	}
 
-      dev->rmem_start = dev->mem_start =
-	  (u_long)ioremap(req.Base, req.Size);
-      dev->rmem_end = dev->mem_end = dev->mem_start + req.Size;
+      dev->mem_start = (u_long)ioremap(req.Base, req.Size);
+      dev->mem_end = dev->mem_start + req.Size;
 
       mem.CardOffset = 0; mem.Page = 0;
       i = CardServices(MapMemPage, link->win, &mem);

  parent reply	other threads:[~2002-04-04  7:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-04  6:54 [PATCH] 2.5.8-pre1 wavelan_cs flaniganr
2002-04-04  7:11 ` Robert Love
2002-04-04  7:18 ` Jeff Garzik [this message]
2002-04-04 17:40   ` Jean Tourrilhes
2002-04-04 19:25     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CABFE55.9@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=dhinds@zen.stanford.edu \
    --cc=flaniganr@intel.co.jp \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox