From: Martin Dalecki <dalecki@evision-ventures.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux-2.5.8-pre1
Date: Thu, 04 Apr 2002 12:19:19 +0200 [thread overview]
Message-ID: <3CAC28A7.1060500@evision-ventures.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0204031714080.12444-100000@penguin.transmeta.com>
By just reading the patch I have came across the following code:
diff -Nru a/arch/cris/drivers/ethernet.c b/arch/cris/drivers/ethernet.c
--- a/arch/cris/drivers/ethernet.c Wed Apr 3 17:11:15 2002
+++ b/arch/cris/drivers/ethernet.c Wed Apr 3 17:11:15 2002
......
@@ -1313,7 +1313,7 @@
static void
e100_clear_network_leds(unsigned long dummy)
{
-
if (led_active && jiffies > led_next_time) {
+
if (led_active && jiffies > time_after(jiffies, led_next_time)) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should almost certainly be instead:
+
if (led_active && time_after(jiffies, led_next_time)) {
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
next prev parent reply other threads:[~2002-04-04 11:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 1:22 Linux-2.5.8-pre1 Linus Torvalds
2002-04-04 3:46 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 3:54 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 20:12 ` Linux-2.5.8-pre1 Linus Torvalds
2002-04-04 20:18 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 20:34 ` Linux-2.5.8-pre1 Dave Jones
2002-04-06 15:36 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-06 17:05 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-06 17:25 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-06 17:30 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-06 19:14 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-04 10:19 ` Martin Dalecki [this message]
2002-04-04 11:45 ` Linux-2.5.8-pre1 Tim Schmielau
2002-04-04 10:49 ` Linux-2.5.8-pre1 Martin Dalecki
2002-04-05 6:02 ` [patch] Linux-2.5.8-pre1 Tim Schmielau
2002-04-04 12:05 ` Linux-2.5.8-pre1 Dave Jones
2002-04-04 15:45 ` IDE/SUPPORT_VLB_SYNC in 2.5.x Geert Uytterhoeven
2002-04-04 14:52 ` Martin Dalecki
2002-04-05 8:26 ` Geert Uytterhoeven
2002-04-04 11:55 ` Linux-2.5.8-pre1 fs/dquot Martin Dalecki
2002-04-04 16:43 ` Alexander Viro
2002-04-04 15:50 ` Martin Dalecki
2002-04-04 22:52 ` Linux-2.5.8-pre1 Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CAC28A7.1060500@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox