From: Martin Dalecki <dalecki@evision-ventures.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: IDE/SUPPORT_VLB_SYNC in 2.5.x
Date: Thu, 04 Apr 2002 16:52:37 +0200 [thread overview]
Message-ID: <3CAC68B5.2040505@evision-ventures.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0204041740550.28139-100000@vervain.sonytel.be>
Geert Uytterhoeven wrote:
> SUPPORT_VLB_SYNC is now unconditionally hardcoded to 1 in
> drivers/ide/ide-taskfile.c.
>
> While most architectures disable it, which no longer works:
>
> | tux$ find include -type f | xargs grep SUPPORT_VLB_SYNC
> | include/asm-cris/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-cris/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/asm-m68k/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-m68k/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/asm-mips/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-mips/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/asm-ppc/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-ppc/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/asm-sparc/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-sparc/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/asm-sparc64/ide.h:#undef SUPPORT_VLB_SYNC
> | include/asm-sparc64/ide.h:#define SUPPORT_VLB_SYNC 0
> | include/linux/ide.h:#ifndef SUPPORT_VLB_SYNC /* 1 to support weird 32-bit chips */
> | include/linux/ide.h:#define SUPPORT_VLB_SYNC 1 /* 0 to reduce kernel size */
>
> Wouldn't it be better to enable it on architectures which can have a VESA local
> bus (ia32 only?) only?
Thank you for pointing it out. Of course it just shouldn't be enabled
unconditionally there. Apparently it "slipped in" during some
compiling for "code coverage". My appologies for the inconvenience.
It will be disabled in the next patch round.
next prev parent reply other threads:[~2002-04-04 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 1:22 Linux-2.5.8-pre1 Linus Torvalds
2002-04-04 3:46 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 3:54 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 20:12 ` Linux-2.5.8-pre1 Linus Torvalds
2002-04-04 20:18 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-04 20:34 ` Linux-2.5.8-pre1 Dave Jones
2002-04-06 15:36 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-06 17:05 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-06 17:25 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-06 17:30 ` Linux-2.5.8-pre1 Larry McVoy
2002-04-06 19:14 ` Linux-2.5.8-pre1 David Woodhouse
2002-04-04 10:19 ` Linux-2.5.8-pre1 Martin Dalecki
2002-04-04 11:45 ` Linux-2.5.8-pre1 Tim Schmielau
2002-04-04 10:49 ` Linux-2.5.8-pre1 Martin Dalecki
2002-04-05 6:02 ` [patch] Linux-2.5.8-pre1 Tim Schmielau
2002-04-04 12:05 ` Linux-2.5.8-pre1 Dave Jones
2002-04-04 15:45 ` IDE/SUPPORT_VLB_SYNC in 2.5.x Geert Uytterhoeven
2002-04-04 14:52 ` Martin Dalecki [this message]
2002-04-05 8:26 ` Geert Uytterhoeven
2002-04-04 11:55 ` Linux-2.5.8-pre1 fs/dquot Martin Dalecki
2002-04-04 16:43 ` Alexander Viro
2002-04-04 15:50 ` Martin Dalecki
2002-04-04 22:52 ` Linux-2.5.8-pre1 Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CAC68B5.2040505@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox