public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Romain Lievin <roms@lpg.ticalc.org>, Julien BLACHE <jb@technologeek.org>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: BKL in tiglusb release function
Date: Thu, 04 Apr 2002 16:38:23 -0800	[thread overview]
Message-ID: <3CACF1FF.2000508@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Is there a reason for the BKL to be used in tiglusb_release()?  Are you 
worried about a race between open and release, or were you just 
following examples from other code?

I'm sure we can remove it safely.  We might need another lock, but it 
won't be much.

-- 
Dave Hansen
haveblue@us.ibm.com

[-- Attachment #2: tiglusb-bkl_remove-2.5.8-pre1.patch --]
[-- Type: text/plain, Size: 389 bytes --]

--- linux-2.5.8-pre1-clean/drivers/usb/tiglusb.c	Thu Apr  4 08:58:26 2002
+++ linux/drivers/usb/tiglusb.c	Thu Apr  4 16:29:31 2002
@@ -128,7 +128,6 @@
 {
 	ptiglusb_t s = (ptiglusb_t) file->private_data;
 
-	lock_kernel ();
 	down (&s->mutex);
 	s->state = _stopped;
 	up (&s->mutex);
@@ -139,7 +138,6 @@
 		wake_up (&s->remove_ok);
 
 	s->opened = 0;
-	unlock_kernel ();
 
 	return 0;
 }

             reply	other threads:[~2002-04-05  0:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-05  0:38 Dave Hansen [this message]
     [not found] ` <3CAD74DA.58561BF7@free.fr>
2002-04-05 16:58   ` BKL in tiglusb release function Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CACF1FF.2000508@us.ibm.com \
    --to=haveblue@us.ibm.com \
    --cc=jb@technologeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=roms@lpg.ticalc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox