From: Andrew Morton <akpm@zip.com.au>
To: Alexander Viro <viro@math.psu.edu>
Cc: Dave Hansen <haveblue@us.ibm.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [WTF] ->setattr() locking changes
Date: Sat, 06 Apr 2002 00:10:55 -0800 [thread overview]
Message-ID: <3CAEAD8F.80E921B3@zip.com.au> (raw)
In-Reply-To: <Pine.GSO.4.21.0204060034240.28391-100000@weyl.math.psu.edu>
ext3 was missed - the removal of the BKL in notify_change
means that the filesytem fails quite quickly on SMP in -pre2.
Sorry, I should have spotted that when the patch floated past.
Please do it this way:
--- linux-2.5.8-pre2/fs/ext3/inode.c Fri Apr 5 17:42:19 2002
+++ 25/fs/ext3/inode.c Fri Apr 5 22:04:47 2002
@@ -2377,6 +2377,8 @@ int ext3_setattr(struct dentry *dentry,
return error;
}
+ lock_kernel();
+
if (attr->ia_valid & ATTR_SIZE && attr->ia_size < inode->i_size) {
handle_t *handle;
@@ -2404,6 +2406,7 @@ int ext3_setattr(struct dentry *dentry,
err_out:
ext3_std_error(inode->i_sb, error);
+ unlock_kernel();
if (!error)
error = rc;
return error;
-
next prev parent reply other threads:[~2002-04-06 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-06 5:43 [WTF] ->setattr() locking changes Alexander Viro
2002-04-06 8:10 ` Andrew Morton [this message]
2002-04-06 16:29 ` Linus Torvalds
2002-04-06 16:52 ` Alexander Viro
2002-04-06 17:17 ` Alexander Viro
2002-04-06 18:23 ` Linus Torvalds
2002-04-06 19:09 ` Alexander Viro
2002-04-06 20:41 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-04-06 18:45 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CAEAD8F.80E921B3@zip.com.au \
--to=akpm@zip.com.au \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox