Re: bug in sch_generic.c:pfifo_fast_enqueue

[Patrick McHardy <kaber@trash.net>]

"David S. Miller" schrieb:
> 
>    From: Patrick McHardy <kaber@trash.net>
>    Date: Mon, 1 Apr 2002 21:43:03 +0200 (CEST)
> 
>    I found a small bug in pfifo_fast_enqueue, instead of
> 
>    if (list->qlen <= skb->dev->tx_queue_len)
> 
>    it should be
> 
>    if (list->qlen <= qdisc->dev->tx_queue_len)
> 
>    i guess.
> 
> skb->dev == qdisc->dev should be invariant when this
> code runs.  So the code is correct, albeit possibly
> confusing.


I (we) are (ab?)using the code to enqueue/dequeue arbitary
packets to a qdisc attached to a software device (imq)
for doing traffic control over multiple interfaces / ingress
traffic control with egress qdiscs, in that case 
skb->dev != qdisc->dev.
Although in normal circumstances the assumption may be right
it fails in this case. It would be nice if you apply my patch
as it doesn't changes anything and enforces correct behaviour
in cases like mine.

Bye,
Patrick