public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: DJ Barrow <dj.barrow@asitatech.com>
Cc: root@chaos.analogic.com,
	"Brian O'Sullivan" <brian.osullivan@asitatech.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: novice coding in /linux/net/ipv4/util.c From: DJ Barrow <dj.barrow@asitatech.com>
Date: Mon, 22 Apr 2002 09:21:09 -0700	[thread overview]
Message-ID: <3CC43875.6010002@candelatech.com> (raw)
In-Reply-To: <Pine.LNX.3.95.1020422113750.11343A-100000@chaos.analogic.com> <20020422160154Z314241-22651+13871@vger.kernel.org>



DJ Barrow wrote:

> Richard,
> I agree The least offensive way would be to pass in a sring from the caller,
> I didn't spot the second endian bug till you mentioned it ;-).


The input should always be in network-byte-order, so there is no
endian problem, at least.  The other problem can be worked around
by the caller, though a second, similar, method that took an pre-allocated
buffer would definately be nice.

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear



  reply	other threads:[~2002-04-22 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-22 15:12 novice coding in /linux/net/ipv4/util.c From: DJ Barrow <dj.barrow@asitatech.com> DJ Barrow
2002-04-22 15:48 ` Richard B. Johnson
2002-04-22 16:03   ` DJ Barrow
2002-04-22 16:21     ` Ben Greear [this message]
2002-04-22 20:32   ` Olaf Titz
     [not found] <20020422151025Z314220-22651+13849@vger.kernel.org.suse.lists.linux.kernel>
2002-04-22 17:07 ` Andi Kleen
2002-04-22 17:19   ` DJ Barrow
2002-04-23 14:15   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC43875.6010002@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=brian.osullivan@asitatech.com \
    --cc=dj.barrow@asitatech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=root@chaos.analogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox