From: Andrew Morton <akpm@zip.com.au>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Alexander Viro <viro@math.psu.edu>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
"Martin J. Bligh" <Martin.Bligh@us.ibm.com>
Subject: Re: locking in sync_old_buffers
Date: Mon, 22 Apr 2002 15:08:14 -0700 [thread overview]
Message-ID: <3CC489CE.19A91699@zip.com.au> (raw)
In-Reply-To: <3CC47A27.4000803@us.ibm.com>
Dave Hansen wrote:
> ...
> --- linux-2.5.8-clean/fs/buffer.c Mon Apr 22 13:45:34 2002
> +++ linux/fs/buffer.c Mon Apr 22 13:45:49 2002
> @@ -2612,10 +2612,8 @@
>
> static void sync_old_buffers(unsigned long dummy)
> {
> - lock_kernel();
> sync_unlocked_inodes();
> sync_supers();
> - unlock_kernel();
>
> for (;;) {
> struct buffer_head *bh;
Al would know better than I, but...
If you're going to do this, then the BKL should be acquired
in fs/super.c:write_super(), so the per-fs ->write_super
functions do not see changed external locking rules.
Possibly, fs/inode.c:write_inode() needs the same treatment.
But Doc/filesystems/Locking says that lock_kernel() is not
held across ->write_inode so there should be no need to take
it on the kupdate path.
That's for 2.4. For 2.5, we'd like sync_old_buffers to just
go away. Do you have time to test
http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.8/everything.patch.gz
-
next prev parent reply other threads:[~2002-04-22 22:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-22 21:01 locking in sync_old_buffers Dave Hansen
2002-04-22 22:08 ` Andrew Morton [this message]
2002-04-22 22:23 ` Dave Hansen
2002-04-22 22:28 ` Linus Torvalds
2002-04-22 22:50 ` Andrew Morton
2002-04-23 1:31 ` Alexander Viro
2002-04-23 18:29 ` Dave Hansen
2002-04-22 22:25 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CC489CE.19A91699@zip.com.au \
--to=akpm@zip.com.au \
--cc=Martin.Bligh@us.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox