From: Arjan van de Ven <arjanv@redhat.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: devfs: BKL *not* taken while opening devices
Date: Mon, 29 Apr 2002 18:21:34 +0100 [thread overview]
Message-ID: <3CCD811E.8689F4B0@redhat.com> (raw)
In-Reply-To: <20020429141301.B16778@flint.arm.linux.org.uk> <3CCD672E.5040005@us.ibm.com>
Dave Hansen wrote:
>
> Russell King wrote:
> > Kernel 2.5.8... Devfs devfs_open() bypasses the normal chrdev_open
> > and blkdev_open functions, and misses out taking the BKL. 2.5.10 is
> > the same.
> >
> > Certainly the tty layer (and probably many of the other devices as
> > well) require the BKL to be taken before calling the open method.
>
> Has the time come to push the BKL down into all of the driver open()s?
> It's going to be a lot of work, but it has to happen eventually, right?
I'm not convinced of that. It's not nearly a critical path and it's
better to get even the "dumb" drivers safe than to risk having big
security holes in there for years to come.
next prev parent reply other threads:[~2002-04-29 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-29 13:13 devfs: BKL *not* taken while opening devices Russell King
2002-04-29 15:30 ` Dave Hansen
2002-04-29 17:21 ` Arjan van de Ven [this message]
2002-04-29 17:40 ` Roman Zippel
2002-04-29 17:46 ` Arjan van de Ven
2002-05-02 16:44 ` Alan Cox
2002-04-29 17:52 ` Dave Hansen
2002-04-30 12:45 ` Russell King
2002-04-30 16:42 ` Dave Hansen
2002-04-30 16:52 ` Arjan van de Ven
2002-04-30 16:58 ` Dave Hansen
2002-04-30 18:26 ` Martin J. Bligh
2002-04-30 17:03 ` Russell King
2002-05-11 0:45 ` Richard Gooch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CCD811E.8689F4B0@redhat.com \
--to=arjanv@redhat.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox