Re: [PATCH] reworked IDE/general tagged command queueing

[Martin Dalecki <dalecki@evision-ventures.com>]

Uz.ytkownik Martin Dalecki napisa?:
> Uz.ytkownik Linus Torvalds napisa?:
> 
>>
>> On Wed, 1 May 2002, Jens Axboe wrote:
>>
>>> I've rewritten parts of the IDE TCQ stuff to be, well, a lot better in
>>> my oppinion. I had to accept that the ata_request and rq->special usage
>>> sucked, it was just one big mess.
>>
>>
>>
>> Looks good.
> 
> 
> Well after a short cross over look at it I agree.
> The generic interface looks sane for me as well. However
> I will have to look a bit deeper, becouse at the first sight
> the double pointer to tag_index looks a bit "overelaborate"
> to me. But I may change my opinnion after looking at the
> actual usage - so please take this small bit of critique
> with a good grain of salt...
> 
> +#define BLK_TAGS_PER_LONG    (sizeof(unsigned long) * 8)
> +#define BLK_TAGS_MASK        (BLK_TAGS_PER_LONG - 1)
> +
> +struct blk_queue_tag {
> + struct request **tag_index;    /* map of busy tags */
> + unsigned long *tag_map;        /* bit map of free/busy tags */
> + struct list_head busy_list;    /* fifo list of busy tags */
> + int busy;            /* current depth */
> + int max_depth;
> +};
> +

Well I revoke my objections. tag_index is fine :-).