From: Andrew Morton <akpm@zip.com.au>
To: Brian Gerst <bgerst@didntduck.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Dave Jones <davej@suse.de>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] percpu updates
Date: Wed, 01 May 2002 15:44:33 -0700 [thread overview]
Message-ID: <3CD06FD1.2E75F5F2@zip.com.au> (raw)
In-Reply-To: <3CD06ACE.1090402@didntduck.org>
Brian Gerst wrote:
>
> These patches convert some of the existing arrays based on NR_CPUS to
> use the new per cpu code.
>
> ...
> -extern struct page_state {
> +struct page_state {
> unsigned long nr_dirty;
> unsigned long nr_locked;
> unsigned long nr_pagecache;
> -} ____cacheline_aligned_in_smp page_states[NR_CPUS];
> +};
> +
> +extern struct page_state __per_cpu_data page_states;
When I did this a couple of weeks back it failed in
mysterious ways and I ended up parking it. Failure
symptoms included negative numbers being reported in
/proc/meminfo for "Locked" and "Dirty".
How well has this been tested? (If the answer
is "not very" then please wait until I've tested
it out...)
-
next prev parent reply other threads:[~2002-05-01 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-01 22:23 [PATCH] percpu updates Brian Gerst
2002-05-01 22:44 ` Andrew Morton [this message]
2002-05-01 22:54 ` Brian Gerst
2002-05-01 23:05 ` Randy.Dunlap
2002-05-01 23:35 ` Alan Cox
2002-05-03 14:59 ` Timothy D. Witham
2002-05-05 4:08 ` Andrew Morton
2002-05-05 16:38 ` Brian Gerst
2002-05-06 8:57 ` Andrew Morton
2002-05-06 12:44 ` Brian Gerst
2002-05-06 7:27 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CD06FD1.2E75F5F2@zip.com.au \
--to=akpm@zip.com.au \
--cc=bgerst@didntduck.org \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox