Re: [PATCH] 2.5.13 IDE PIO mode Fix

Martin Dalecki
2002-05-05T01:13:15Z

Użytkownik Andries.Brouwer@cwi.nl napisał:
> I found this bug in 2.5.10 first. And caused ext2 FS corruption.
> We are porting Linux to PC-9801 architecture (made by NEC Japan).
> It has PIO ONLY IDE I/F. So please check PIO mode too.
> # Our porting status - 2.2.x/2.4.x done and updating. 2.5.x partial.
>
> diff -urN linux-2.5.10/drivers/ide/ide-taskfile.c linux/drivers/ide/ide-taskfile.c
> --- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
> +++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
> @@ -202,7 +202,7 @@
> ata_write_slow(drive, buffer, wcount);
> else
> #endif
> - ata_write_16(drive, buffer, wcount<<1);
> + ata_write_16(drive, buffer, wcount);
> }
> }
>
> Excellent!

Thank you for confirmations. This even streamlines the code to what
it was intendid to be.

BTW.> The next thing I plan to break is host chips initialization,
since Jens introduced several additional ide_dma_action_t fields
for no good reaons... I decided to remove them all as next... :-).