From: Andrew Morton <akpm@zip.com.au>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/10] suppress allocation warnings for radix-tree allocations
Date: Sun, 05 May 2002 15:06:10 -0700 [thread overview]
Message-ID: <3CD5ACD1.CBB2ACC8@zip.com.au> (raw)
In-Reply-To: <3CD59BAD.37BD6A51@zip.com.au> <E174TuG-0004As-00@starship>
Daniel Phillips wrote:
>
> On Sunday 05 May 2002 22:53, Andrew Morton wrote:
> > The recently-added page allocation failure warning generates a lot of
> > noise due to radix-tree node allocation failures. Those messages are
> > not interesting.
> >
> > But I think the warning is otherwise useful - "I got an allocation
> > failure and then it crashed" is better than "it crashed".
> >
> > The patch suppresses the message for ratnode allocation failures.
> >
> > =====================================
> >
> > --- 2.5.13/mm/vmscan.c~radix-tree-warning Sun May 5 13:31:59 2002
> > +++ 2.5.13-akpm/mm/vmscan.c Sun May 5 13:31:59 2002
> > @@ -58,6 +58,7 @@ swap_out_add_to_swap_cache(struct page *
> > int ret;
> >
> > current->flags &= ~PF_MEMALLOC;
> > + current->flags |= PF_RADIX_TREE;
>
> Isn't that really 'PF_NO_WARN_ALLOC'?
>
Yup, that would make more sense.
Or __GFP_I_DONT_REALLY_CARE ;)
-
next prev parent reply other threads:[~2002-05-05 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-05 20:53 [patch 1/10] suppress allocation warnings for radix-tree allocations Andrew Morton
2002-05-05 21:51 ` Daniel Phillips
2002-05-05 22:06 ` Andrew Morton [this message]
2002-05-05 22:51 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CD5ACD1.CBB2ACC8@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox