From: Martin Dalecki <dalecki@evision-ventures.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Osamu Tomita <tomita@cinet.co.jp>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.14 IDE CD-ROM PIO mode
Date: Tue, 07 May 2002 12:42:02 +0200 [thread overview]
Message-ID: <3CD7AF7A.6040705@evision-ventures.com> (raw)
In-Reply-To: <3CD79586.63E17164@cinet.co.jp> <3CD7A500.8030509@evision-ventures.com> <20020507124109.A32573@infradead.org>
Uz.ytkownik Christoph Hellwig napisa?:
> On Tue, May 07, 2002 at 11:57:20AM +0200, Martin Dalecki wrote:
>
>>>@@ -962,7 +962,7 @@
>>>
>>> /* First, figure out if we need to bit-bucket
>>> any of the leading sectors. */
>>>- nskip = MIN(rq->current_nr_sectors - bio_sectors(rq->bio), sectors_to_transfer);
>>>+ nskip = MIN((int)(rq->current_nr_sectors - bio_sectors(rq->bio)), sectors_to_transfer);
>>
>
> What about a s/MIN/min/g in the idea driver to easily catch such bugs?
Good idea partially already implemented :-).
At least the generic code and the host chip driver code are alread
switched to using those "chatch them" macros.
next prev parent reply other threads:[~2002-05-07 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-07 8:51 [PATCH] 2.5.14 IDE CD-ROM PIO mode Osamu Tomita
2002-05-07 9:57 ` Martin Dalecki
2002-05-07 11:41 ` Christoph Hellwig
2002-05-07 10:42 ` Martin Dalecki [this message]
2002-05-07 14:29 ` Bartlomiej Zolnierkiewicz
2002-05-07 13:51 ` Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CD7AF7A.6040705@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomita@cinet.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox