From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365E4C433F5 for ; Fri, 22 Apr 2022 12:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiDVM5n (ORCPT ); Fri, 22 Apr 2022 08:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233872AbiDVM4w (ORCPT ); Fri, 22 Apr 2022 08:56:52 -0400 Received: from hutie.ust.cz (hutie.ust.cz [185.8.165.127]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D72B52B00; Fri, 22 Apr 2022 05:53:58 -0700 (PDT) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1650632035; bh=Rr2b05NP3wGMyQRhBvV1IUry/zX4H2Dk7P7NRyvj4Tc=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=S2seNKR6yDu5lByMYBXtbttAJdb1b0jPUip8DgWFAkRfkxD3ictQ41YsHmflWx7Jt ZD8Gqu1wZkLj4wbBUECqLWYLgwPXkly6M/+vFY+k4B81Erg0Fdt7CREtFGbIoACJlI LHvoYzn8dmLlHQFq0Wf1Gr97+ZrFIpCXzoHBcxCs= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver From: =?utf-8?Q?Martin_Povi=C5=A1er?= In-Reply-To: Date: Fri, 22 Apr 2022 14:53:54 +0200 Cc: =?utf-8?Q?Martin_Povi=C5=A1er?= , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis , Hector Martin , Sven Peter Content-Transfer-Encoding: quoted-printable Message-Id: <3CD969AD-7316-4D83-AD92-CC85ED817125@cutebit.org> References: <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org> <6F6130F3-381C-4AB7-B618-CDC4C4A37C9B@cutebit.org> To: Mark Brown Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 22. 4. 2022, at 14:44, Mark Brown wrote: >=20 > On Fri, Apr 22, 2022 at 02:36:03PM +0200, Martin Povi=C5=A1er wrote: >=20 >>> Ah, I think the confusion here is that I'm using slot and channel >>> interchangably whereas you're saying that previously the driver = would >>> allocate two channels to each speaker with duplicate data? >=20 >> I guess you could say that. Not that there=E2=80=99s duplicate data = on the I2S >> bus, but the speaker amp would previously be configured to look for = the >> left and right channel in the same TDM slot (see e.g. set_tdm_slot of >> tas2770 [0]). (Each speaker amp drives a single speaker, but it = still >> has a notion of left and right channel.) >=20 > Oh, I see - the speaker actually allows configuration of the slots > independently. Usually the left/right thing on mono devices only does > something for I2S where the bus clocking enforces that there be both > left and right channels. Either configuration is fine by me TBH, if = you > can do that then you could just keep them mapped to the same channel > then mark the control as disabled since it should have no effect. Well but is there some established way to mark a control as disabled? Another issue here is that if I disable it I can=E2=80=99t leave the = routing control in it=E2=80=99s default value, which is =E2=80=98I2C Offset=E2=80=99= and makes the speaker amp ignore the slot mapping.