* pdc202xx.c fails to compile in 2.5.15
2002-05-11 16:59 [PATCH] 2.5.15 IDE 60 Martin Dalecki
@ 2002-05-12 19:19 ` Zlatko Calusic
2002-05-12 19:40 ` Jurriaan on Alpha
2002-05-12 22:00 ` Petr Vandrovec
0 siblings, 2 replies; 6+ messages in thread
From: Zlatko Calusic @ 2002-05-12 19:19 UTC (permalink / raw)
To: Martin Dalecki; +Cc: Kernel Mailing List
pdc202xx.x fails to compile in 2.5.15. Error messages below.
pdc202xx.c:1453: unknown field `exnablebits' specified in initializer
pdc202xx.c:1453: warning: braces around scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: braces around scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: initialization makes pointer from integer without a cast
pdc202xx.c:1453: warning: excess elements in scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: excess elements in scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: braces around scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: initialization makes pointer from integer without a cast
pdc202xx.c:1453: warning: excess elements in scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: excess elements in scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
pdc202xx.c:1453: warning: excess elements in scalar initializer
pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
make[3]: *** [pdc202xx.o] Error 1
--
Zlatko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pdc202xx.c fails to compile in 2.5.15
2002-05-12 19:19 ` pdc202xx.c fails to compile in 2.5.15 Zlatko Calusic
@ 2002-05-12 19:40 ` Jurriaan on Alpha
2002-05-12 22:00 ` Petr Vandrovec
1 sibling, 0 replies; 6+ messages in thread
From: Jurriaan on Alpha @ 2002-05-12 19:40 UTC (permalink / raw)
To: Zlatko Calusic; +Cc: Martin Dalecki, Kernel Mailing List
From: Zlatko Calusic <zlatko.calusic@iskon.hr>
Date: Sun, May 12, 2002 at 09:19:22PM +0200
> pdc202xx.x fails to compile in 2.5.15. Error messages below.
>
>
> pdc202xx.c:1453: unknown field `exnablebits' specified in initializer
That's a simple typing error - replace exnable by enable.
Good luck,
Jurriaan
--
The man who thinks he is smarter than his wife is married to a very smart
woman.
Debian GNU/Linux 2.4.19p8 on Alpha 988 bogomips load:0.12 0.06 0.01
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pdc202xx.c fails to compile in 2.5.15
2002-05-12 19:19 ` pdc202xx.c fails to compile in 2.5.15 Zlatko Calusic
2002-05-12 19:40 ` Jurriaan on Alpha
@ 2002-05-12 22:00 ` Petr Vandrovec
2002-05-13 12:03 ` Alan Cox
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vandrovec @ 2002-05-12 22:00 UTC (permalink / raw)
To: Zlatko Calusic; +Cc: Martin Dalecki, Kernel Mailing List
On Sun, May 12, 2002 at 09:19:22PM +0200, Zlatko Calusic wrote:
> pdc202xx.x fails to compile in 2.5.15. Error messages below.
>
> pdc202xx.c:1453: unknown field `exnablebits' specified in initializer
> pdc202xx.c:1453: warning: braces around scalar initializer
> pdc202xx.c:1453: warning: (near initialization for `chipsets[3].init_dma')
> make[3]: *** [pdc202xx.o] Error 1
If you have PDC20265 like I have, you must also remove test on device class,
as 20265 reports itself as generic mass storage (class 0x0180) and not as
IDE (it is real IDE, not RAID, really).
Because of there are apparently devices on which you must check device class
(2.5.14 talks about CY82C693 and IT8172G), I'll leave proper fix on Martin,
but simple fix below work fine on my Asus A7V.
Petr Vandrovec
vandrove@vc.cvut.cz
--- drivers/ide/ide-pci.c Sun May 12 02:46:44 2002
+++ drivers/ide/ide-pci.c Fri May 10 00:25:29 2002
@@ -701,7 +701,7 @@
hpt374_device_order_fixup(dev, d);
} else if (d->vendor == PCI_VENDOR_ID_PROMISE && d->device == PCI_DEVICE_ID_PROMISE_20268R)
pdc20270_device_order_fixup(dev, d);
- else if ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
+ else if (1 || (dev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
printk(KERN_INFO "ATA: %s (%04x:%04x) on PCI slot %s\n",
dev->name, vendor, device, dev->slot_name);
setup_pci_device(dev, d);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pdc202xx.c fails to compile in 2.5.15
2002-05-12 22:00 ` Petr Vandrovec
@ 2002-05-13 12:03 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2002-05-13 12:03 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: Zlatko Calusic, Martin Dalecki, Kernel Mailing List
> If you have PDC20265 like I have, you must also remove test on device class,
> as 20265 reports itself as generic mass storage (class 0x0180) and not as
> IDE (it is real IDE, not RAID, really).
It reports itself that way so that the windows ide disk driver doesn't
grab and it and dos/bios don't get odd ideas
> Because of there are apparently devices on which you must check device class
> (2.5.14 talks about CY82C693 and IT8172G), I'll leave proper fix on Martin,
> but simple fix below work fine on my Asus A7V.
You need to do specific checks for the device in question. Removing the
class check btw is something anyone reading this message should not do
even in the same situation unless they know precisely what other
mass storage class devices they have present. You can easily trash a
raid array otherwise
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pdc202xx.c fails to compile in 2.5.15
2002-05-13 12:58 pdc202xx.c fails to compile in 2.5.15 Franz Sirl
@ 2002-05-13 12:03 ` Martin Dalecki
0 siblings, 0 replies; 6+ messages in thread
From: Martin Dalecki @ 2002-05-13 12:03 UTC (permalink / raw)
To: Franz Sirl; +Cc: linux-kernel, Alan Cox
Uz.ytkownik Franz Sirl napisa?:
> Alan Cox wrote:
>
>> > Because of there are apparently devices on which you must check
>> device class
>> > (2.5.14 talks about CY82C693 and IT8172G), I'll leave proper fix on
>> Martin,
>> > but simple fix below work fine on my Asus A7V.
>>
>> You need to do specific checks for the device in question. Removing the
>> class check btw is something anyone reading this message should not do
>> even in the same situation unless they know precisely what other
>> mass storage class devices they have present. You can easily trash a
>> raid array otherwise
>
>
> I think you are probably talking about the class check for unknown
> devices a few lines above in 2.5.15. Removing the class check when a
> driver already claimed responsibility just reinstates what we had in
> 2.4. The removal is in IDE 61.
Witht the exception that there are not proper vendor id cheks in
2.4 there. Oh well...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pdc202xx.c fails to compile in 2.5.15
@ 2002-05-13 12:58 Franz Sirl
2002-05-13 12:03 ` Martin Dalecki
0 siblings, 1 reply; 6+ messages in thread
From: Franz Sirl @ 2002-05-13 12:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Cox
Alan Cox wrote:
> > Because of there are apparently devices on which you must check device
> class
> > (2.5.14 talks about CY82C693 and IT8172G), I'll leave proper fix on Martin,
> > but simple fix below work fine on my Asus A7V.
>
>You need to do specific checks for the device in question. Removing the
>class check btw is something anyone reading this message should not do
>even in the same situation unless they know precisely what other
>mass storage class devices they have present. You can easily trash a
>raid array otherwise
I think you are probably talking about the class check for unknown devices
a few lines above in 2.5.15. Removing the class check when a driver already
claimed responsibility just reinstates what we had in 2.4. The removal is
in IDE 61.
Franz.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-05-13 13:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-13 12:58 pdc202xx.c fails to compile in 2.5.15 Franz Sirl
2002-05-13 12:03 ` Martin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-05-11 16:59 [PATCH] 2.5.15 IDE 60 Martin Dalecki
2002-05-12 19:19 ` pdc202xx.c fails to compile in 2.5.15 Zlatko Calusic
2002-05-12 19:40 ` Jurriaan on Alpha
2002-05-12 22:00 ` Petr Vandrovec
2002-05-13 12:03 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox