Re: Agpgart for 845G

Re: Agpgart for 845G

[Nicolas Aspert]

Hello

> 
> Patch for Intel 845G agpgart support
> 

diff'd against which version of the kernel ?


> +    { PCI_DEVICE_ID_INTEL_845_G_0,
> +		 PCI_VENDOR_ID_INTEL,
> +		 INTEL_I845_G,
> +		 "Intel",
> +		 "i845G",
> +		 intel_830mp_setup },

Are you sure that 830mp and 845g have exactly the same addresses to 
write/read to ? BTW, I can't find any datasheet for 845g on Intel's 
website ... do you have any at hand ?



> +			if (i810_dev == NULL) {
> +                                /* 
> +                                 * We probably have a I830MP chipset
> +                                 * with an external graphics
> +                                 * card. It will be initialized later 
> +                                 */
> +				agp_bridge.type = INTEL_I845_G;
> +				break;
> +			}

Are you sure about the comment :-)) ?



a+

Nicolas.
PS: CC any answer to me, I am not on the list...
-- 
Nicolas Aspert      Signal Processing Institute (ITS)
Swiss Federal Institute of Technology (EPFL)

Re: Agpgart for 845G

[Abraham vd Merwe]

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Hi Nicolas!

> > +    { PCI_DEVICE_ID_INTEL_845_G_0,
> > +		 PCI_VENDOR_ID_INTEL,
> > +		 INTEL_I845_G,
> > +		 "Intel",
> > +		 "i845G",
> > +		 intel_830mp_setup },
> 
> Are you sure that 830mp and 845g have exactly the same addresses to 
> write/read to ? BTW, I can't find any datasheet for 845g on Intel's 
> website ... do you have any at hand ?

The 845g chipset is the little brother of 830mp - it's memory allocation
didn't change a bit, so above setup is actually correct.

> > +			if (i810_dev == NULL) {
> > +                                /* 
> > +                                 * We probably have a I830MP chipset
> > +                                 * with an external graphics
> > +                                 * card. It will be initialized later 
> > +                                 */
> > +				agp_bridge.type = INTEL_I845_G;
> > +				break;
> > +			}
> 
> Are you sure about the comment :-)) ?

Smells like cut & paste to me (;

-- 

Regards
 Abraham

"Intelligence without character is a dangerous thing."
-- G. Steinem

__________________________________________________________
 Abraham vd Merwe - 2d3D, Inc.

 Device Driver Development, Outsourcing, Embedded Systems

  Cell: +27 82 565 4451         Snailmail:
   Tel: +27 21 761 7549            Block C, Aintree Park
   Fax: +27 21 761 7648            Doncaster Road
 Email: abraham@2d3d.co.za         Kenilworth, 7700
  Http: http://www.2d3d.com        South Africa


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Agpgart for 845G

[graeme fisher]

[-- Attachment #1: Type: text/plain, Size: 57 bytes --]

Hi,

Patch for Intel 845G agpgart support

Cheers
Graeme

[-- Attachment #2: agp_845G.diff --]
[-- Type: text/plain, Size: 2450 bytes --]

diff -ruNp linux/drivers/char/agp/agp.h my_linux/drivers/char/agp/agp.h
--- linux/drivers/char/agp/agp.h	Wed Apr 10 00:11:46 2002
+++ my_linux/drivers/char/agp/agp.h	Tue Apr  9 05:15:07 2002
@@ -170,6 +170,12 @@ struct agp_bridge_data {
 #ifndef PCI_DEVICE_ID_INTEL_810_0
 #define PCI_DEVICE_ID_INTEL_810_0       0x7120
 #endif
+#ifndef PCI_DEVICE_ID_INTEL_845_G_0
+#define PCI_DEVICE_ID_INTEL_845_G_0	0x2560
+#endif
+#ifndef PCI_DEVICE_ID_INTEL_845_G_1
+#define PCI_DEVICE_ID_INTEL_845_G_1     0x2562
+#endif
 #ifndef PCI_DEVICE_ID_INTEL_830_M_0
 #define PCI_DEVICE_ID_INTEL_830_M_0	0x3575
 #endif
diff -ruNp linux/drivers/char/agp/agpgart_be.c my_linux/drivers/char/agp/agpgart_be.c
--- linux/drivers/char/agp/agpgart_be.c	Wed Apr 10 00:11:46 2002
+++ my_linux/drivers/char/agp/agpgart_be.c	Tue Apr  9 05:13:23 2002
@@ -3662,6 +3662,12 @@ static struct {
 		"Intel",
 		"i830M",
 		intel_830mp_setup },
+    { PCI_DEVICE_ID_INTEL_845_G_0,
+		 PCI_VENDOR_ID_INTEL,
+		 INTEL_I845_G,
+		 "Intel",
+		 "i845G",
+		 intel_830mp_setup },
 	{ PCI_DEVICE_ID_INTEL_840_0,
 		PCI_VENDOR_ID_INTEL,
 		INTEL_I840,
@@ -3979,6 +3985,28 @@ static int __init agp_find_supported_dev
 			agp_bridge.type = INTEL_I810;
 			return intel_i810_setup(i810_dev);
 
+		case PCI_DEVICE_ID_INTEL_845_G_0:
+			i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
+					PCI_DEVICE_ID_INTEL_845_G_1, NULL);
+			if(i810_dev && PCI_FUNC(i810_dev->devfn) != 0) {
+				i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
+					PCI_DEVICE_ID_INTEL_845_G_1, i810_dev);
+			}
+
+			if (i810_dev == NULL) {
+                                /* 
+                                 * We probably have a I830MP chipset
+                                 * with an external graphics
+                                 * card. It will be initialized later 
+                                 */
+				agp_bridge.type = INTEL_I845_G;
+				break;
+			}
+			printk(KERN_INFO PFX "Detected an Intel "
+				   "845G Chipset.\n");
+			agp_bridge.type = INTEL_I810;
+			return intel_i830_setup(i810_dev);
+		   
 		case PCI_DEVICE_ID_INTEL_830_M_0:
 			i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
 					PCI_DEVICE_ID_INTEL_830_M_1, NULL);
--- linux/include/linux/agp_backend.h	Sat Nov 10 00:11:15 2001
+++ my_linux/include/linux/agp_backend.h	Tue Apr  9 05:17:56 2002
@@ -48,6 +48,7 @@ enum chipset_type {
 	INTEL_I815,
 	INTEL_I820,
 	INTEL_I830_M,
+	INTEL_I845_G,
 	INTEL_I840,
 	INTEL_I845,
 	INTEL_I850,