Re: Agpgart patch for the i845G

Re: Agpgart patch for the i845G

[graeme fisher]

Hi Nicolas

The addresses are the same for the i830mp and i845g so instead of
duplicating the code I just used the i830 setup functions for the 845g
as well.

Strictly speaking the comment that you referred to in your mail should
be changed to reflect i845g and not i830mp.

Thanks for your comments

Graeme Fisher

Re: Agpgart patch for the i845G

[Nicolas Aspert]

Hello


> The addresses are the same for the i830mp and i845g so instead of
> duplicating the code I just used the i830 setup functions for the 845g
> as well.

OK. I was just a bit worried by the fact that I could not find any docs 
on this chipset (I have almost all Intel AGP docs so this is a bit 
frustrating :-), but if it works for you, I guess the patch is OK ;-)

> Strictly speaking the comment that you referred to in your mail should
> be changed to reflect i845g and not i830mp.

:-))

Maybe add a few more comments to justify the fact that you call 
intel_830mp_setup, s.t. people reading the code in a few months won't 
ask themselves what the heck is this 845g stuff.

a+

Nicolas.
-- 
Nicolas Aspert      Signal Processing Institute (ITS)
Swiss Federal Institute of Technology (EPFL)