From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 15 May 2002 09:36:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 15 May 2002 09:36:27 -0400 Received: from gateway.ukaea.org.uk ([194.128.63.73]:11861 "EHLO fuspcnjc.culham.ukaea.org.uk") by vger.kernel.org with ESMTP id ; Wed, 15 May 2002 09:36:26 -0400 Message-ID: <3CE263FF.FC17E7C0@ukaea.org.uk> Date: Wed, 15 May 2002 14:34:55 +0100 From: Neil Conway X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-31 i686) X-Accept-Language: en MIME-Version: 1.0 To: Alan Cox CC: Martin Dalecki , Anton Altaparmakov , Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.5.15 IDE 61 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: > > > The problem is that with the busy flag on we are wasting quite > > a significant amount of CPU time spinning around it for no good... > > Why spin on the busy flag. Instead you just let the person who clears > the flag check the pending work and do it. Isn't that what happens? Since when are we spinning on busy? Certainly not in vanilla 2.5.14, unless I'm much mistaken. Martin - I haven't read your last couple of patches yet but did you really change it this drastically? Neil