Re: [PATCH] 2.5.15 IDE 61

Russell King
2002-05-14T11:38:40Z

On Tue, May 14, 2002 at 12:21:44PM +0200, Martin Dalecki wrote:
> Well in the next patch round the hwgroup will be replaced with
> a spin lock, which is supposed to be shared between channels which need
> forced access serialization between them. Please look
> at patches 62a and 63 :-).

Something here smells fishy here - you shouldn't hold a spinlock for a long
time (a long time === spinlocking, setting up the drive, possibly scheduling,
transferring data, getting status, then unlocking). Also, remember,
spinlocks are no-ops on uniprocessor systems.

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux