From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 21 May 2002 14:37:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 21 May 2002 14:37:29 -0400 Received: from smtpzilla1.xs4all.nl ([194.109.127.137]:260 "EHLO smtpzilla1.xs4all.nl") by vger.kernel.org with ESMTP id ; Tue, 21 May 2002 14:36:48 -0400 Message-ID: <3CEA93B5.B2E62FC7@linux-m68k.org> Date: Tue, 21 May 2002 20:36:37 +0200 From: Roman Zippel X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.4.18 i686) X-Accept-Language: en MIME-Version: 1.0 To: Linus Torvalds CC: Kernel Mailing List Subject: Re: Linux-2.5.17 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, Linus Torvalds wrote: > I don't think there is any validity any more in the "opaque type" comment, > and I'd rather expose the fact that it _has_ to have the rss computations > inside of it than have more made-up interfaces to hide it. > > The fact is, the rss cannot be computed anywhere else any more, so why > play games about it? Basically I could agree with it, but something looks wrong. Why exactly is pte_free_tlb() needed in first place? Why does it call tlb_remove_page()? A page mapped into user space has little to do with a page used as page table. Latter is never in the user tlb, so it doesn't need to be removed from it, so calling tlb_remove_page() is just a more complicated way of calling __free_page() or am I missing something? bye, Roman