* re: [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile
@ 2002-05-23 22:32 Dan Kegel
2002-05-23 23:05 ` Kevin P. Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Dan Kegel @ 2002-05-23 22:32 UTC (permalink / raw)
To: Kevin P. Fleming, linux-kernel@vger.kernel.org
> The patch below is required for fs/nfs/nfsroot.c to compile in 2.4.19-pre8:
>
> diff -X dontdiff -urN linux/fs/nfs/nfsroot.c linux-nfsroot/fs/nfs/nfsroot.c
> --- linux/fs/nfs/nfsroot.c Thu May 23 12:04:17 2002
> +++ linux-nfsroot/fs/nfs/nfsroot.c Thu May 23 12:10:11 2002
> @@ -344,7 +344,7 @@
> struct sockaddr_in sin;
>
> printk(KERN_NOTICE "Looking up port of RPC %d/%d on %s\n",
> - program, version, in_ntoa(servaddr));
> + program, version, NIPQUAD(servaddr));
> set_sockaddr(&sin, servaddr, 0);
> return rpc_getport_external(&sin, program, version, proto);
> }
Er, shouldn't you change the %s to a %d.%d.%d.%d?
- Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile
2002-05-23 22:32 [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile Dan Kegel
@ 2002-05-23 23:05 ` Kevin P. Fleming
0 siblings, 0 replies; 3+ messages in thread
From: Kevin P. Fleming @ 2002-05-23 23:05 UTC (permalink / raw)
To: dank, linux-kernel; +Cc: trond.myklebust
Doh! Here's a corrected patch (other places in the kernel use %u instead of
%d, so that's what I used):
--- linux/fs/nfs/nfsroot.c Thu May 23 12:04:17 2002
+++ linux-nfsroot/fs/nfs/nfsroot.c Thu May 23 16:02:29 2002
@@ -343,8 +343,8 @@
{
struct sockaddr_in sin;
- printk(KERN_NOTICE "Looking up port of RPC %d/%d on %s\n",
- program, version, in_ntoa(servaddr));
+ printk(KERN_NOTICE "Looking up port of RPC %d/%d on %u.%u.%u.%u\n",
+ program, version, NIPQUAD(servaddr));
set_sockaddr(&sin, servaddr, 0);
return rpc_getport_external(&sin, program, version, proto);
}
----- Original Message -----
From: "Dan Kegel" <dank@kegel.com>
To: "Kevin P. Fleming" <kevin@labsysgrp.com>; <linux-kernel@vger.kernel.org>
Sent: Thursday, May 23, 2002 03:32 PM
Subject: re: [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile
<snip>
> Er, shouldn't you change the %s to a %d.%d.%d.%d?
> - Dan
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile
@ 2002-05-23 19:34 Kevin P. Fleming
0 siblings, 0 replies; 3+ messages in thread
From: Kevin P. Fleming @ 2002-05-23 19:34 UTC (permalink / raw)
To: linux-kernel; +Cc: trond.myklebust
The patch below is required for fs/nfs/nfsroot.c to compile in 2.4.19-pre8:
diff -X dontdiff -urN linux/fs/nfs/nfsroot.c linux-nfsroot/fs/nfs/nfsroot.c
--- linux/fs/nfs/nfsroot.c Thu May 23 12:04:17 2002
+++ linux-nfsroot/fs/nfs/nfsroot.c Thu May 23 12:10:11 2002
@@ -344,7 +344,7 @@
struct sockaddr_in sin;
printk(KERN_NOTICE "Looking up port of RPC %d/%d on %s\n",
- program, version, in_ntoa(servaddr));
+ program, version, NIPQUAD(servaddr));
set_sockaddr(&sin, servaddr, 0);
return rpc_getport_external(&sin, program, version, proto);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-05-23 23:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-23 22:32 [PATCH] patch for 2.4.19-pre8 nfsroot.c to compile Dan Kegel
2002-05-23 23:05 ` Kevin P. Fleming
-- strict thread matches above, loose matches on Subject: below --
2002-05-23 19:34 Kevin P. Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox