From: Martin Dalecki <dalecki@evision-ventures.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] New driver for Artop [Acard] controllers.
Date: Fri, 24 May 2002 15:33:42 +0200 [thread overview]
Message-ID: <3CEE4136.8000500@evision-ventures.com> (raw)
In-Reply-To: <Pine.SOL.4.30.0205241620440.16894-100000@mion.elka.pw.edu.pl>
Uz.ytkownik Bartlomiej Zolnierkiewicz napisa?:
> Hi!
>
> I have a very quick look over patch/driver... looks quite ok...
Agreed. And I agree with Vojtech on his view about the
coding style in the old driver (or better the leak of it).
Andrej Panin already noticed as well that it looks more like
perl then C.
Therefore I would rather tend toward the proposal of killing
the old code altogether.
> But it doesn't support multiple controllers. We should add 'unsigned
> long private' to 'ata_channel struct' and store index in the chipset
> table there.
> You can remove duplicate entries from module data table.
>
> BTW: please don't touch pdc202xx.c I am playing with it...
>
> greets
> --
> bkz
>
>
--
- phone: +49 214 8656 283
- job: eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort: ru_RU.KOI8-R
next prev parent reply other threads:[~2002-05-24 14:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-24 14:29 [patch] New driver for Artop [Acard] controllers Bartlomiej Zolnierkiewicz
2002-05-24 13:33 ` Martin Dalecki [this message]
2002-05-24 14:50 ` Vojtech Pavlik
2002-05-24 14:07 ` Martin Dalecki
2002-05-24 15:17 ` Vojtech Pavlik
2002-05-24 15:29 ` Vojtech Pavlik
2002-05-24 15:57 ` Vojtech Pavlik
2002-05-25 5:07 ` Andre Hedrick
2002-05-26 9:50 ` Andre Hedrick
2002-05-26 11:08 ` Vojtech Pavlik
2002-05-26 11:05 ` Vojtech Pavlik
2002-05-26 12:42 ` Ruth Ivimey-Cook
2002-05-26 12:48 ` Vojtech Pavlik
2002-05-26 23:08 ` Andre Hedrick
2002-05-27 0:42 ` Alan Cox
2002-05-27 0:17 ` Andre Hedrick
2002-05-28 14:09 ` Rob Landley
2002-05-29 8:15 ` Vojtech Pavlik
2002-05-27 3:57 ` Copyright Violation (Re: [patch] New driver for Artop [Acard] controllers.) Andre Hedrick
2002-05-27 15:04 ` Pavel Machek
2002-05-27 14:58 ` [patch] New driver for Artop [Acard] controllers Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2002-05-24 13:46 Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CEE4136.8000500@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox