* [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h
@ 2002-05-26 13:22 Vojtech Pavlik
2002-05-27 8:01 ` Martin Dalecki
0 siblings, 1 reply; 5+ messages in thread
From: Vojtech Pavlik @ 2002-05-26 13:22 UTC (permalink / raw)
To: Martin Dalecki, linux-kernel
ChangeSet@1.585, 2002-05-26 15:19:41+02:00, vojtech@twilight.ucw.cz
This cset moves a PCI ID definition from ide-pci.c to
pci_ids.h where it belongs.
drivers/ide/ide-pci.c | 6 +-----
include/linux/pci_ids.h | 4 ++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff -Nru a/drivers/ide/ide-pci.c b/drivers/ide/ide-pci.c
--- a/drivers/ide/ide-pci.c Sun May 26 15:20:16 2002
+++ b/drivers/ide/ide-pci.c Sun May 26 15:20:16 2002
@@ -27,10 +27,6 @@
#include "pcihost.h"
-/* Missing PCI device IDs: */
-#define PCI_VENDOR_ID_HINT 0x3388
-#define PCI_DEVICE_ID_HINT 0x8013
-
/*
* This is the list of registered PCI chipset driver data structures.
*/
@@ -756,7 +752,7 @@
},
{
vendor: PCI_VENDOR_ID_HINT,
- device: PCI_DEVICE_ID_HINT,
+ device: PCI_DEVICE_ID_HINT_VXPROII_IDE,
bootable: ON_BOARD
},
{
diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h
--- a/include/linux/pci_ids.h Sun May 26 15:20:16 2002
+++ b/include/linux/pci_ids.h Sun May 26 15:20:16 2002
@@ -1787,3 +1787,7 @@
#define PCI_DEVICE_ID_MICROGATE_USC 0x0010
#define PCI_DEVICE_ID_MICROGATE_SCC 0x0020
#define PCI_DEVICE_ID_MICROGATE_SCA 0x0030
+
+#define PCI_VENDOR_ID_HINT 0x3388
+#define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
+
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h
2002-05-26 13:22 [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h Vojtech Pavlik
@ 2002-05-27 8:01 ` Martin Dalecki
2002-05-27 9:20 ` Dave Jones
2002-05-27 9:40 ` Vojtech Pavlik
0 siblings, 2 replies; 5+ messages in thread
From: Martin Dalecki @ 2002-05-27 8:01 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: linux-kernel
Uz.ytkownik Vojtech Pavlik napisa?:
> ChangeSet@1.585, 2002-05-26 15:19:41+02:00, vojtech@twilight.ucw.cz
> This cset moves a PCI ID definition from ide-pci.c to
> pci_ids.h where it belongs.
>
>
> drivers/ide/ide-pci.c | 6 +-----
> include/linux/pci_ids.h | 4 ++++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>
> diff -Nru a/drivers/ide/ide-pci.c b/drivers/ide/ide-pci.c
> --- a/drivers/ide/ide-pci.c Sun May 26 15:20:16 2002
> +++ b/drivers/ide/ide-pci.c Sun May 26 15:20:16 2002
> @@ -27,10 +27,6 @@
>
> #include "pcihost.h"
>
> -/* Missing PCI device IDs: */
> -#define PCI_VENDOR_ID_HINT 0x3388
> -#define PCI_DEVICE_ID_HINT 0x8013
> -
> /*
> * This is the list of registered PCI chipset driver data structures.
> */
> @@ -756,7 +752,7 @@
> },
> {
> vendor: PCI_VENDOR_ID_HINT,
> - device: PCI_DEVICE_ID_HINT,
> + device: PCI_DEVICE_ID_HINT_VXPROII_IDE,
> bootable: ON_BOARD
> },
> {
> diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> --- a/include/linux/pci_ids.h Sun May 26 15:20:16 2002
> +++ b/include/linux/pci_ids.h Sun May 26 15:20:16 2002
> @@ -1787,3 +1787,7 @@
> #define PCI_DEVICE_ID_MICROGATE_USC 0x0010
> #define PCI_DEVICE_ID_MICROGATE_SCC 0x0020
> #define PCI_DEVICE_ID_MICROGATE_SCA 0x0030
> +
> +#define PCI_VENDOR_ID_HINT 0x3388
> +#define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
> +
Please note that pci_ids.h. is a generated file. The ids have to be
moved to the ancestor of it as well.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h
2002-05-27 9:20 ` Dave Jones
@ 2002-05-27 8:22 ` Martin Dalecki
0 siblings, 0 replies; 5+ messages in thread
From: Martin Dalecki @ 2002-05-27 8:22 UTC (permalink / raw)
To: Dave Jones; +Cc: Vojtech Pavlik, linux-kernel
Uz.ytkownik Dave Jones napisa?:
> On Mon, May 27, 2002 at 10:01:04AM +0200, Martin Dalecki wrote:
> > Please note that pci_ids.h. is a generated file.
>
> No. You're thinking of drivers/pci/devlist.h and classlist.h
> If you looks at pci_ids.h, you'll notice we only have IDs in there
> for devices Linux actually supports.
I stand corrected indeed. OK time for the next cup of coffe this
morning to get me awake finally :-).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h
2002-05-27 8:01 ` Martin Dalecki
@ 2002-05-27 9:20 ` Dave Jones
2002-05-27 8:22 ` Martin Dalecki
2002-05-27 9:40 ` Vojtech Pavlik
1 sibling, 1 reply; 5+ messages in thread
From: Dave Jones @ 2002-05-27 9:20 UTC (permalink / raw)
To: Martin Dalecki; +Cc: Vojtech Pavlik, linux-kernel
On Mon, May 27, 2002 at 10:01:04AM +0200, Martin Dalecki wrote:
> Please note that pci_ids.h. is a generated file.
No. You're thinking of drivers/pci/devlist.h and classlist.h
If you looks at pci_ids.h, you'll notice we only have IDs in there
for devices Linux actually supports.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h
2002-05-27 8:01 ` Martin Dalecki
2002-05-27 9:20 ` Dave Jones
@ 2002-05-27 9:40 ` Vojtech Pavlik
1 sibling, 0 replies; 5+ messages in thread
From: Vojtech Pavlik @ 2002-05-27 9:40 UTC (permalink / raw)
To: Martin Dalecki; +Cc: Vojtech Pavlik, linux-kernel
On Mon, May 27, 2002 at 10:01:04AM +0200, Martin Dalecki wrote:
> > diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > --- a/include/linux/pci_ids.h Sun May 26 15:20:16 2002
> > +++ b/include/linux/pci_ids.h Sun May 26 15:20:16 2002
> > @@ -1787,3 +1787,7 @@
> > #define PCI_DEVICE_ID_MICROGATE_USC 0x0010
> > #define PCI_DEVICE_ID_MICROGATE_SCC 0x0020
> > #define PCI_DEVICE_ID_MICROGATE_SCA 0x0030
> > +
> > +#define PCI_VENDOR_ID_HINT 0x3388
> > +#define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
> > +
>
> Please note that pci_ids.h. is a generated file. The ids have to be
> moved to the ancestor of it as well.
Generated? I don't think so. devlist.h is, same for classlist.h, but not
pci_ids.h
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-05-27 9:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-26 13:22 [patch] Trivial: move PCI ID definitions from ide-pci.c to pci_ids.h Vojtech Pavlik
2002-05-27 8:01 ` Martin Dalecki
2002-05-27 9:20 ` Dave Jones
2002-05-27 8:22 ` Martin Dalecki
2002-05-27 9:40 ` Vojtech Pavlik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox