public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Dalecki <dalecki@evision-ventures.com>
To: Jan Kara <jack@suse.cz>
Cc: torvalds@transmeta.com,
	Nathan Scott <nathans@wobbly.melbourne.sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2/3 Quota changes ported to 2.5.18
Date: Wed, 29 May 2002 15:55:28 +0200	[thread overview]
Message-ID: <3CF4DDD0.8090806@evision-ventures.com> (raw)
In-Reply-To: <20020529144510.GB9503@atrey.karlin.mff.cuni.cz>

Jan Kara wrote:
>   This second patch changes sysctl interface to use reasonable names in
> /proc/sys/fs/quota/
> 
> 								Honza
> 

Please note that the _dquots suffix for the alocated and
free entires of struct dqstats is:

1. Entierly redundant. (dqstats.allocated counts dquots what else?)

2. Orthogonal to the leak of it for the other fields.

  static inline void put_inuse(struct dquot *dquot)
@@ -238,12 +238,12 @@
  	/* We add to the back of inuse list so we don't have to restart
  	 * when traversing this list and we block */
  	list_add(&dquot->dq_inuse, inuse_list.prev);
- 
++dqstats_array[DQSTATS_ALLOCATED];
+ 
dqstats.allocated_dquots++;
  }



      reply	other threads:[~2002-05-29 14:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-29 14:45 [PATCH] 2/3 Quota changes ported to 2.5.18 Jan Kara
2002-05-29 13:55 ` Martin Dalecki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CF4DDD0.8090806@evision-ventures.com \
    --to=dalecki@evision-ventures.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathans@wobbly.melbourne.sgi.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox