Re: [PATCH] 2.5.18 IDE 73

Gerald Champagne
2002-05-29T14:26:49Z

>
> Dear Gerald please look closer. The hdparm -i is executing the
> drive id command directly and does *not* rely on the internally
> permanently dragged around id structure. So the change I did
> is entierly fine. Just go ahead and check whatever hdparm -i /dev/hdx
> reports the proper thing after changing some dma setting.
> It does - I did check it :-).

Ah, sorry about that. I missed that in your patch. The previous
version of the ioctl just returned copied the values from the id
structure. Doing the id on the fly is much more accurate and will catch
any other fields that happen to change over time.

> BTW> The next thing to be gone is simple the fact that we drag
> around the id information permanently, where infact only
> some capabilitie fields are sucked out of it and the
> device identification string is only needed for reporting
> during boot-up.

That sounds good. That would make it easier to see what values from the
id are actually used.

Thanks.

Gerald