From: Eli Carter <eli.carter@inet.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.5.19
Date: Wed, 29 May 2002 15:38:29 -0500 [thread overview]
Message-ID: <3CF53C45.3000606@inet.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0205291146510.1344-100000@penguin.transmeta.com> <20020529211702.E30585@flint.arm.linux.org.uk>
Russell King wrote:
> The following change appeared in 2.5.19:
>
> xx- a/drivers/video/cyber2000fb.c Wed May 29 11:43:02 2002
> xx+ b/drivers/video/cyber2000fb.c Wed May 29 11:43:02 2002
> @@ -1729,9 +1729,8 @@
> }
>
> static struct pci_device_id cyberpro_pci_table[] __devinitdata = {
> -// Not yet
> -// { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682,
> -// PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 },
> + { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682,
> + PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 },
> { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2000,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_CYBERPRO_2000 },
> { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2010,
>
> This is completely wrong - the driver has been tested NOT to work on
> the Integraphics 1682. As such, please do uncomment these lines.
>
> In addition, I'm disappointed that no one forwarded the patch for
> maintainer approval PRIOR to submitting it to Linus.
>
> Linus, I request that you apply the following patch. Thanks.
>
> --- orig/drivers/video/cyber2000fb.c Mon May 6 16:54:10 2002
> +++ linux/drivers/video/cyber2000fb.c Mon May 13 10:48:13 2002
> @@ -1729,8 +1729,9 @@
> }
>
> static struct pci_device_id cyberpro_pci_table[] __devinitdata = {
> - { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682,
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 },
> +// Not yet
> +// { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682,
> +// PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 },
> { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2000,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_CYBERPRO_2000 },
> { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2010,
>
>
How about s/Not yet/This driver has been tested NOT to work on the
Integraphics 1682. Do not enable with out contacting the maintainer./
instead? That might avoid the problem recurring...
Just a thought, ignore if you wish.
Eli
--------------------. "If it ain't broke now,
Eli Carter \ it will be soon." -- crypto-gram
eli.carter(a)inet.com `-------------------------------------------------
next prev parent reply other threads:[~2002-05-29 20:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-29 18:50 Linux 2.5.19 Linus Torvalds
2002-05-29 19:42 ` Jason Lunz
2002-05-29 20:17 ` Russell King
2002-05-29 20:38 ` Eli Carter [this message]
2002-05-29 20:44 ` James Simmons
2002-05-29 20:47 ` Russell King
2002-05-29 22:22 ` Martin Dalecki
2002-05-29 23:25 ` Russell King
2002-05-29 22:42 ` Martin Dalecki
2002-05-29 23:52 ` Russell King
2002-05-29 23:00 ` Martin Dalecki
2002-05-29 22:43 ` James Simmons
2002-05-29 22:29 ` Martin Dalecki
2002-05-29 23:31 ` Russell King
2002-05-30 5:10 ` Framebuffer policy [ was Re: Linux 2.5.19] James Simmons
2002-05-29 20:37 ` [PATCH] Missing include in drivers/base/bus.c and drivers/pci/pci-driver.c Tom Rini
2002-05-29 22:24 ` Linux 2.5.19 Tom Rini
2002-05-30 1:29 ` Rusty Russell
2002-05-29 23:01 ` Matthias Andree
2002-05-29 23:35 ` J.A. Magallon
2002-05-30 14:15 ` [PATCH] 2.5.19 blk.h and more about the ugly kids Martin Dalecki
2002-05-31 11:09 ` [PATCH] 2.5.19 IDE 76 Martin Dalecki
2002-05-31 18:17 ` [PATCH] 2.5.19 IDE 77 Martin Dalecki
2002-06-02 6:04 ` [PATCH] 2.5.19 IDE 78 Martin Dalecki
2002-06-02 8:16 ` Paul Dickson
2002-06-02 9:21 ` Paul Mackerras
2002-06-02 19:34 ` Martin Dalecki
2002-06-02 21:36 ` Bartlomiej Zolnierkiewicz
2002-06-02 21:59 ` Paul Mackerras
2002-06-03 4:47 ` Martin Dalecki
2002-06-02 6:06 ` [PATCH} 2.5.19 IDE 79 Martin Dalecki
2002-06-02 6:07 ` [PATCH] 2.5.19 IDE 80 Martin Dalecki
2002-06-02 19:45 ` [PATCH] 2.5.19 IDE 81 Martin Dalecki
2002-06-02 20:13 ` [PATCH] 2.5.19 IDE 82 Martin Dalecki
[not found] <805239813@toto.iv>
2002-05-30 1:38 ` Linux 2.5.19 Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CF53C45.3000606@inet.com \
--to=eli.carter@inet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox