Re: [PATCH] intel-x86 model config cleanup

[Jeff Garzik <jgarzik@mandrakesoft.com>]

J.A. Magallon wrote:

>  
>
>Then for each model you would define its generic CONFIG_M<arch>, and
>the specific features not contained in the generic. And then define
>the rest of features based on generic.
>The CONFIG_M<arch> would serve as a flag for 'this cpu has all features
>of a generic xxx'.
>
>Or if you are worried about namespace pollution these could be named
>CONFIG_CPU_VENDOR_, CONFIG_CPU_, CONFIG_CPU_M.
>  
>


Your division of categories (snipped from above quoted) seems ok.

The basic thing to remember is that "generic_foo" or "cpu_intel_foo" 
options should very rarely, if ever, appear in the config.in or sources. 
 We simply want to use the generic or cpu-specific user selection to 
determine (a) compiler flags, (b) CONFIG_xxx symbols for specific CPU 
features and optimizations, [like CONFIG_X86_F00F_BUG] and maybe (c) 
enable and disable CPU-specific drivers.  (c) will be a special case, 
since very few drivers should require a specific CPU type... but some 
drivers simply don't work on 386.

    Jeff