Re: [PATCH] 2.4.19-pre8 fs/nfs/nfsroot.c - in_ntoa

Re: [PATCH] 2.4.19-pre8 fs/nfs/nfsroot.c - in_ntoa

[David S. Miller]

   From: Peter Wächtler <pwaechtler@loewe-komp.de>
   Date: Thu, 30 May 2002 14:04:18 +0200

   Somehow a call to in_ntoa went into the kernel.
   With that you can't linke the kernel, when CONFIG_ROOT_NFS=y
   is on.
   
   fs/fs.o: In function `root_nfs_getport':
   fs/fs.o(.text.init+0x10e1): undefined reference to `in_ntoa'
   make: *** [vmlinux] Fehler 1

No, in fact in_ntoa always had existed, except that I finally
killed it.  You're supposed to replace it with NIPQUAD not
the endian-unfriendly %x.

I've sent Marcelo fixes for this if someone else hasn't beaten
me to it already.

[PATCH] 2.4.19-pre8 fs/nfs/nfsroot.c - in_ntoa

[Peter Wächtler]

Somehow a call to in_ntoa went into the kernel.
With that you can't linke the kernel, when CONFIG_ROOT_NFS=y
is on.



fs/fs.o: In function `root_nfs_getport':
fs/fs.o(.text.init+0x10e1): undefined reference to `in_ntoa'
make: *** [vmlinux] Fehler 1



--- fs/nfs/nfsroot.c.orig       Thu May 30 13:58:30 2002
+++ fs/nfs/nfsroot.c    Thu May 30 13:59:01 2002
@@ -343,8 +343,8 @@
  {
         struct sockaddr_in sin;

-       printk(KERN_NOTICE "Looking up port of RPC %d/%d on %s\n",
-               program, version, in_ntoa(servaddr));
+       printk(KERN_NOTICE "Looking up port of RPC %d/%d on 0x%X\n",
+               program, version, servaddr);
         set_sockaddr(&sin, servaddr, 0);
         return rpc_getport_external(&sin, program, version, proto);
  }