From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Chris Mason <mason@suse.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 12/16] fix race between writeback and unlink
Date: Mon, 03 Jun 2002 15:30:09 -0700 [thread overview]
Message-ID: <3CFBEDEE.EE74C5B1@zip.com.au> (raw)
In-Reply-To: <1023142233.31475.23.camel@tiny> <Pine.LNX.4.44.0206031514110.868-100000@home.transmeta.com>
Linus Torvalds wrote:
>
> On 3 Jun 2002, Chris Mason wrote:
> >
> > Or am I missing something?
>
> No. I think that in the long run we really would want all of the writeback
> preallocation should happen in the "struct file", not in "struct inode".
> And they should be released at file close ("release()"), not at iput()
> time.
That would be a lot nicer.
But why does ext2_put_inode() even exist? We're already throwing
away the prealloc window in ext2_release_file? I guess for
shared mappings over spares files: if all file handles have
closed off, we still need to make allocations against that
inode, yes?
-
next prev parent reply other threads:[~2002-06-03 22:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-01 8:43 [patch 12/16] fix race between writeback and unlink Andrew Morton
2002-06-01 16:42 ` Linus Torvalds
2002-06-01 19:19 ` Andrew Morton
2002-06-01 20:04 ` William Lee Irwin III
2002-06-01 22:25 ` Andrew Morton
2002-06-03 4:27 ` [RFC] iput() cleanup (was Re: [patch 12/16] fix race between writeback and unlink) Linus Torvalds
2002-06-03 16:26 ` Andreas Dilger
2002-06-03 16:47 ` Linus Torvalds
2002-06-03 19:09 ` Chris Mason
2002-06-03 19:34 ` Linus Torvalds
2002-06-03 19:49 ` Chris Mason
2002-06-03 19:55 ` Linus Torvalds
2002-06-03 22:10 ` [patch 12/16] fix race between writeback and unlink Chris Mason
2002-06-03 22:19 ` Linus Torvalds
2002-06-03 22:30 ` Andrew Morton [this message]
2002-06-04 18:47 ` Linus Torvalds
2002-06-04 20:15 ` Andrew Morton
2002-06-04 20:23 ` Linus Torvalds
2002-06-04 20:40 ` Andrew Morton
2002-06-04 21:37 ` Linus Torvalds
2002-06-04 22:04 ` Benjamin LaHaise
2002-06-04 22:08 ` Andrew Morton
2002-07-07 20:38 ` Riley Williams
2002-06-04 22:05 ` Craig Milo Rogers
2002-06-04 22:08 ` Linus Torvalds
2002-06-03 22:36 ` Chris Mason
2002-06-03 22:47 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFBEDEE.EE74C5B1@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox