public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Dalecki <dalecki@evision-ventures.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Jens Axboe <axboe@suse.de>,
	Linus Torvalds <torvalds@transmeta.com>,
	linux-kernel@vger.kernel.org
Subject: Re: PATCH/RFC: fix 2.5.20 ramdisk
Date: Tue, 04 Jun 2002 09:54:14 +0200	[thread overview]
Message-ID: <3CFC7226.2010101@evision-ventures.com> (raw)
In-Reply-To: <20020603180627.A23056@flint.arm.linux.org.uk> <20020604083525.GA2512@suse.de> <20020604094532.A30552@flint.arm.linux.org.uk>

Russell King wrote:
> On Tue, Jun 04, 2002 at 10:35:25AM +0200, Jens Axboe wrote:
> 
>>On Mon, Jun 03 2002, Russell King wrote:
>>
>>>2.5.20 seems to be incapable of executing binaries in a ramdisk-based
>>>root filesystem.  The ramdisk in question is an ext2fs, with a 1K
>>>block size loaded via the compressed ramdisk loader in do_mounts().
>>>
>>>It appears that, in the case of a 1K block sized filesystem, we attempt
>>>to read two 512-byte sectors into a BIO vector.  The first one is copied
>>>into the first 512 bytes.  The second sector, however, is copied over
>>>the first 512 bytes.  Obviously not what we really want.
>>
>>Looks good.
> 
> 
> Ok, rev. 2, slightly cleaned up:
> 
> --- orig/drivers/block/rd.c	Wed May 29 21:40:26 2002
> +++ linux/drivers/block/rd.c	Tue Jun  4 09:44:21 2002
> @@ -144,6 +144,7 @@
>  {
>  	struct address_space * mapping;
>  	unsigned long index;
> +	unsigned int vec_offset;


Just a small nit. Shouldn't taht be size_t ?


  reply	other threads:[~2002-06-04  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03 17:06 PATCH/RFC: fix 2.5.20 ramdisk Russell King
2002-06-04  8:35 ` Jens Axboe
2002-06-04  8:45   ` Russell King
2002-06-04  7:54     ` Martin Dalecki [this message]
2002-06-04  8:53       ` Jens Axboe
2002-06-04  8:54       ` Russell King
2002-06-04  8:08         ` Martin Dalecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CFC7226.2010101@evision-ventures.com \
    --to=dalecki@evision-ventures.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox