From: Gerald Teschl <gerald.teschl@univie.ac.at>
To: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
torvalds@transmeta.com
Cc: zwane@commfireservices.com
Subject: [PATCH] opl3sa2 isapnp activation fix
Date: Tue, 04 Jun 2002 17:57:52 +0200 [thread overview]
Message-ID: <3CFCE380.8070704@univie.ac.at> (raw)
Hi,
this is the final version of my patch which fixes the isapnp activation
of opl3sa2 based
cards which require dma=0 as discussed with Zwane Mwaikambo.
Gerald
--- linux-2.4.18-4/drivers/sound/opl3sa2.c.orig Thu May 2 23:36:45 2002
+++ linux-2.4.18-4/drivers/sound/opl3sa2.c Tue Jun 4 16:09:50 2002
@@ -57,6 +57,7 @@
* (Jan 7, 2001)
* Zwane Mwaikambo Added PM support. (Dec 4 2001)
* Zwane Mwaikambo Code, data structure cleanups. (Feb 15 2002)
+ * Gerald Teschl Fixed ISA PnP activate. (Jun 02 2002)
*
*/
@@ -869,10 +870,24 @@
}
else {
if(dev->activate(dev) < 0) {
- printk(KERN_WARNING PFX "ISA PnP activate failed\n");
- opl3sa2_state[card].activated = 0;
- return -ENODEV;
+ /*
+ * isapnp.c disallows dma=0 but some opl3sa2 cards need it.
+ * So we set dma by hand and try again
+ */
+ if (dma < 0 || dma > 7)
+ dma= 0;
+ if (dma2 < 0 || dma2 >7)
+ dma2= 1;
+ isapnp_resource_change(&dev->dma_resource[0], dma, 1);
+ isapnp_resource_change(&dev->dma_resource[1], dma2, 1);
}
+ if(!dev->active)
+ if (dev->activate(dev) < 0) {
+ printk(KERN_WARNING PFX "ISA PnP activate failed.\n");
+ opl3sa2_state[card].activated = 0;
+ return -ENODEV;
+ }
+ opl3sa2_state[card].activated = 1;
printk(KERN_DEBUG
PFX "Activated ISA PnP card %d (active=%d)\n",
next reply other threads:[~2002-06-04 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-04 15:57 Gerald Teschl [this message]
2002-06-04 15:42 ` [PATCH] opl3sa2 isapnp activation fix Zwane Mwaikambo
2002-06-04 15:55 ` Zwane Mwaikambo
2002-06-04 17:34 ` Gerald Teschl
2002-06-04 17:33 ` Zwane Mwaikambo
2002-06-04 15:48 ` Zwane Mwaikambo
[not found] <Pine.LNX.4.44.0206051414200.26634-100000@netfinity.realnet.co.sz>
2002-06-05 15:05 ` Gerald Teschl
-- strict thread matches above, loose matches on Subject: below --
2002-06-06 18:44 Gerald Teschl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFCE380.8070704@univie.ac.at \
--to=gerald.teschl@univie.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@commfireservices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox