Re: [patch 12/16] fix race between writeback and unlink

Andrew Morton
2002-06-03T22:31:28Z

Linus Torvalds wrote:
>
> On 3 Jun 2002, Chris Mason wrote:
> >
> > Or am I missing something?
>
> No. I think that in the long run we really would want all of the writeback
> preallocation should happen in the "struct file", not in "struct inode".
> And they should be released at file close ("release()"), not at iput()
> time.

That would be a lot nicer.

But why does ext2_put_inode() even exist? We're already throwing
away the prealloc window in ext2_release_file? I guess for
shared mappings over spares files: if all file handles have
closed off, we still need to make allocations against that
inode, yes?

-