public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: lei_hu@ali.com.tw, alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update for ALi Audio Driver (0.14.10)
Date: Thu, 06 Jun 2002 14:09:35 -0400	[thread overview]
Message-ID: <3CFFA55F.8000008@mandrakesoft.com> (raw)
In-Reply-To: <OF7057B5B9.A6CA3C3B-ON48256BD0.0020BE4E@ali.com.tw> <1023365907.22186.9.camel@irongate.swansea.linux.org.uk>

Alan Cox wrote:

>On Thu, 2002-06-06 at 07:27, lei_hu@ali.com.tw wrote:
>  
>
>>Dear all
>> I rewrite the part to read/write registers of the audio codec  for Ali 5451
>>Audio Driver.
>>    
>>
>
>The formatting seems to have gone a bit strange but I'll clean that up
>and merge the change
>  
>


Why?  Hardware semaphores are notorious for causing hangs.  Nobody is 
sharing the hardware under Linux, so I think we should enable access on 
init, and not disable access until driver close.  IMO the mixer should 
be guarded by a Linux kernel semaphore...  I have a patch from Thomas 
Sailer (I think) lying around somewhere that does just that to the via 
audio driver.  Maybe we can adapt it.
(I cc'd this little detail, in my ali/trident.c patch review, to you)

    Jeff





  reply	other threads:[~2002-06-06 18:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-06  6:27 [PATCH] update for ALi Audio Driver (0.14.10) lei_hu
2002-06-06  6:46 ` David S. Miller
2002-06-06 12:18 ` Alan Cox
2002-06-06 18:09   ` Jeff Garzik [this message]
2002-06-06 23:47     ` Alan Cox
2002-06-07  0:19       ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2002-06-07  1:52 lei_hu
2002-06-07  2:49 lei_hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CFFA55F.8000008@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=lei_hu@ali.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox