From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Alan Cox <alan@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
lei_hu@ali.com.tw, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update for ALi Audio Driver (0.14.10)
Date: Thu, 06 Jun 2002 20:19:57 -0400 [thread overview]
Message-ID: <3CFFFC2D.8010104@mandrakesoft.com> (raw)
In-Reply-To: <200206062347.g56NlwZ17861@devserv.devel.redhat.com>
Alan Cox wrote:
>>Why? Hardware semaphores are notorious for causing hangs. Nobody is
>>sharing the hardware under Linux, so I think we should enable access on
>>init, and not disable access until driver close. IMO the mixer should
>>be guarded by a Linux kernel semaphore... I have a patch from Thomas
>>Sailer (I think) lying around somewhere that does just that to the via
>>audio driver. Maybe we can adapt it.
>>(I cc'd this little detail, in my ali/trident.c patch review, to you)
>>
>>
>
>So add a timeout to it ?
>
>
There is a problem in via audio, that seems to be present in trident.c
too: trident_ioctl_mixdev doesn't protect the call to
codec->mixer_ioctl, which in turn can read and write to the AC97 codec.
I'm saying, (1) hardware semaphores are error prone and (2) are we using
the hardware sem to work around this lack of locking on ->mixer_ioctl?
Jeff
next prev parent reply other threads:[~2002-06-07 0:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-06 6:27 [PATCH] update for ALi Audio Driver (0.14.10) lei_hu
2002-06-06 6:46 ` David S. Miller
2002-06-06 12:18 ` Alan Cox
2002-06-06 18:09 ` Jeff Garzik
2002-06-06 23:47 ` Alan Cox
2002-06-07 0:19 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-07 1:52 lei_hu
2002-06-07 2:49 lei_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CFFFC2D.8010104@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=lei_hu@ali.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox