From: Brian Gerst <bgerst@didntduck.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] missing GET_CPU_IDX in i386 entry.S
Date: Sat, 08 Jun 2002 11:33:01 -0400 [thread overview]
Message-ID: <3D0223AD.4030208@quark.didntduck.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
resume_kernel uses CPU_IDX but never uses GET_CPU_IDX to get the index.
This is an issue when smp and preemption are both enabled. I also
removed the unused GET_CURRENT_CPU_IDX.
--
Brian Gerst
[-- Attachment #2: cpu_idx-1 --]
[-- Type: text/plain, Size: 727 bytes --]
diff -urN linux-bk/arch/i386/kernel/entry.S linux/arch/i386/kernel/entry.S
--- linux-bk/arch/i386/kernel/entry.S Wed May 29 15:06:00 2002
+++ linux/arch/i386/kernel/entry.S Sat Jun 8 10:44:44 2002
@@ -83,13 +83,9 @@
#define GET_CPU_IDX \
movl TI_CPU(%ebx), %eax; \
shll $irq_array_shift, %eax
-#define GET_CURRENT_CPU_IDX \
- GET_THREAD_INFO(%ebx); \
- GET_CPU_IDX
#define CPU_IDX (,%eax)
#else
#define GET_CPU_IDX
-#define GET_CURRENT_CPU_IDX GET_THREAD_INFO(%ebx)
#define CPU_IDX
#endif
@@ -236,6 +232,7 @@
movl TI_FLAGS(%ebx), %ecx
testb $_TIF_NEED_RESCHED, %cl
jz restore_all
+ GET_CPU_IDX
movl irq_stat+local_bh_count CPU_IDX, %ecx
addl irq_stat+local_irq_count CPU_IDX, %ecx
jnz restore_all
next reply other threads:[~2002-06-08 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-08 15:33 Brian Gerst [this message]
2002-06-09 5:48 ` [PATCH] missing GET_CPU_IDX in i386 entry.S george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D0223AD.4030208@quark.didntduck.org \
--to=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox