From: Manik Raina <manik@cisco.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: "Thomas 'Dent' Mirlacher" <dent@cosy.sbg.ac.at>,
Andreas Dilger <adilger@clusterfs.com>, Dan Aloni <da-x@gmx.net>,
Lightweight patch manager <patch@luckynet.dynu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.21 - list.h cleanup
Date: Mon, 10 Jun 2002 22:56:24 +0530 [thread overview]
Message-ID: <3D04E140.76633075@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0206100954250.30535-100000@home.transmeta.com>
> The linux coding style _tends_ to avoid using typedefs. It's not a hard
> rule (and I did in fact apply this patch, since it otherwise looked fine),
> but it's fairly common to use an explicit "struct xxxx" instead of
> "xxxx_t".
>
Besides , if someone's browsing the code using 'gid' one would
have to first discover where xxxx_t is defined and realise it's
typedef'ed to struct _xxxx_t and then we'd start to find where
the heck _xxxx_t is .
I'm not saying code needs to be written keeping in mind ease
with which we can run code browsing tools, but avoiding unnecessary
typedefs can certainly help here.
next prev parent reply other threads:[~2002-06-10 17:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-09 11:09 [PATCH][2.5] introduce list_move macros Lightweight patch manager
2002-06-09 11:23 ` Mark Zealey
2002-06-10 14:17 ` Thunder from the hill
2002-06-09 11:48 ` OGAWA Hirofumi
2002-06-09 12:02 ` Thomas 'Dent' Mirlacher
2002-06-09 12:01 ` Russell King
2002-06-09 12:42 ` [PATCH][2.5] introduce list_move macros (revisited) Lightweight patch manager
2002-06-10 15:14 ` Dan Aloni
2002-06-10 15:28 ` [PATCH] 2.5.21 - list.h cleanup Dan Aloni
2002-06-10 15:45 ` Thunder from the hill
2002-06-10 16:37 ` Andreas Dilger
2002-06-10 16:50 ` Thomas 'Dent' Mirlacher
2002-06-10 17:02 ` Linus Torvalds
2002-06-10 17:07 ` Thomas 'Dent' Mirlacher
2002-06-10 17:21 ` Linus Torvalds
2002-06-11 8:00 ` Rusty Russell
2002-06-11 8:33 ` Linus Torvalds
2002-06-11 8:48 ` Martin Dalecki
2002-06-11 9:04 ` Martin Dalecki
2002-06-11 9:14 ` Rusty Russell
2002-06-12 19:45 ` Ingo Molnar
2002-06-13 5:51 ` Rusty Russell
2002-06-13 14:18 ` Ingo Molnar
2002-06-11 14:52 ` george anzinger
2002-06-11 16:03 ` Daniel Phillips
2002-06-12 1:10 ` Rusty Russell
2002-06-12 1:29 ` Linus Torvalds
2002-06-12 6:02 ` Rusty Russell
2002-06-12 7:11 ` Martin Dalecki
2002-06-12 7:27 ` Andrew Morton
2002-06-11 17:54 ` Gerrit Huizenga
2002-06-12 3:49 ` Rusty Russell
2002-06-12 17:30 ` Gerrit Huizenga
2002-06-10 17:26 ` Manik Raina [this message]
2002-06-10 17:51 ` Dan Aloni
2002-06-10 21:28 ` Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D04E140.76633075@cisco.com \
--to=manik@cisco.com \
--cc=adilger@clusterfs.com \
--cc=da-x@gmx.net \
--cc=dent@cosy.sbg.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=patch@luckynet.dynu.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox