Re: [PATCH] 2.5.21 IDE 87

John Weber
2002-06-11T19:09:06Z

Martin Dalecki wrote:
> Sun Jun 9 15:31:56 CEST 2002 ide-clean-87
>
> - Sync with 2.5.21
>
> - Don't call put_device inside idedisk_cleanup(). This is apparently
> triggering
> some bug inside the handling of device trees. Or we don't register the
> device
> properly within the tree. Check this later.
>
> - Further work on the channel register file access locking. Push the
> locking
> out from __ide_end_request to ide_end_request. Rename those functions to
> respective __ata_end_request() and ata_end_request().
>
> - Move ide_wait_status to device.c rename it to ata_status_poll().
>
> - Further work on locking scope issues.
>
> - devfs showed us once again that it changed the policy from agnostic
> numbers
> to unpleasant string names. What a piece of crap!

FYI, this latest cleanup fixes the oops I reported earlier...
not that anyone cared :).

flushing ide devices: hda <1> Unable to handle kernel NULL pointer at
address 00000004
*pde = 000000
Oops: 0002
CPU: 0
EIP: 0010:[<c01a692c>] Not tainted
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010202
eax: c03077d0 ebx: c03077b8 ecx: 00000000 edx: 00000000
esi: c258e000 edi: c029ef40 ebp: c030766c esp: c258fe40
ds: 0018 es: 0018 ss: 0018
Stack: c030766c c03077b8 c0307540 00000001 c01a6d24 c03077b8 c0295788
c030766c
c01eaf9e c03077b8 c0307540 c0307540 c01e271f c030766c c0307670
c029e9cc
00000000 00000003 bffffcd8 c0122fdd c029e9cc 00000003 00000000
4321fedc
Call Trace: [<c01a6d24>] [<c01eaf9d>] [<c01e271f>] [<c0122fdd>] [<c0123576>]
[<c011331e>] [<c0121413>] [<c01217fe>] [<c0122438>]
[<c01512e0>] [<c013e01a>]
[<c013c373>] [<c013c422>] [<c010740f>]
Code: 89 4a 04 89 11 89 40 04 89 43 18 ff 4e 10 8b 46 08 83 e0 08

-o) J o h n W e b e r
/\\ john.weber@linuxhq.com
_\/v http://www.linuxhq.com/people/weber/