From: Andrew Morton <akpm@zip.com.au>
To: Keith Owens <kaos@ocs.com.au>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.18 no timestamp update on modified mmapped files
Date: Mon, 10 Jun 2002 23:39:46 -0700 [thread overview]
Message-ID: <3D059B32.8F3F13AC@zip.com.au> (raw)
In-Reply-To: <10339.1023773628@kao2.melbourne.sgi.com> <3D0595F7.A21AE62B@zip.com.au>
Andrew Morton wrote:
>
> ...
> --- 2.4.19-pre10/mm/vmscan.c~mmap-mtime Mon Jun 10 23:00:28 2002
> +++ 2.4.19-pre10-akpm/mm/vmscan.c Mon Jun 10 23:04:34 2002
> @@ -405,6 +405,9 @@ static int shrink_cache(int nr_pages, zo
> page_cache_get(page);
> spin_unlock(&pagemap_lru_lock);
>
> + if (!PageSwapCache(page))
> + update_mtime(page->mapping->host);
> +
> writepage(page);
> page_cache_release(page);
>
Actually, calling mark_inode_dirty here could well cause
the complex filesystems to explode under high VM pressure.
Probably, we should only touch the file inside msync()
(in 2.4 kernels, at least).
-
next prev parent reply other threads:[~2002-06-11 6:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-11 5:33 2.4.18 no timestamp update on modified mmapped files Keith Owens
2002-06-11 6:17 ` Andrew Morton
2002-06-11 6:29 ` Keith Owens
2002-06-11 6:49 ` Andrew Morton
2002-06-11 7:07 ` Keith Owens
2002-06-11 7:28 ` Andrew Morton
2002-06-11 9:10 ` Hugh Dickins
2002-06-11 9:33 ` Andrew Morton
2002-06-11 9:51 ` Hugh Dickins
2002-06-12 7:40 ` Alan Cox
2002-06-12 7:56 ` Andrew Morton
2002-06-12 14:52 ` Hugh Dickins
2002-06-13 2:25 ` jw schultz
2002-06-13 9:58 ` Hugh Dickins
2002-06-13 10:40 ` jw schultz
2002-06-11 18:09 ` Robert Love
2002-06-12 17:17 ` Pavel Machek
2002-06-11 6:39 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-15 5:24 Kevin Easton
2002-06-15 8:10 ` Hugh Dickins
2002-06-15 9:12 ` Kevin Easton
2002-06-15 9:23 ` Russell King
2002-06-16 4:35 Kevin Easton
2002-06-16 16:35 ` Hugh Dickins
2002-06-19 17:57 Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D059B32.8F3F13AC@zip.com.au \
--to=akpm@zip.com.au \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox