public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.18 no timestamp update on modified mmapped files
Date: Mon, 10 Jun 2002 23:49:02 -0700	[thread overview]
Message-ID: <3D059D5E.C9F9F659@zip.com.au> (raw)
In-Reply-To: Your message of "Mon, 10 Jun 2002 23:17:27 MST." <3D0595F7.A21AE62B@zip.com.au> <11043.1023776994@kao2.melbourne.sgi.com>

Keith Owens wrote:
> 
> On Mon, 10 Jun 2002 23:17:27 -0700,
> Andrew Morton <akpm@zip.com.au> wrote:
> >Keith Owens wrote:
> >>
> >> fd = open("foo", O_RDWR);
> >> map = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> >> ... modify the mapped pages ...
> >> munmap(map, size);
> >> close(fd);
> >>
> >> The timestamp on foo is not updated, even though the contents have
> >> changed.  Adding msync(map, size, MS_[A]SYNC) before munmap makes no
> >> difference.  2.4.19-pre10 has no obvious fixes for this problem.
> 
> >What do the standards say?
> >
> >http://www.opengroup.org/onlinepubs/007904975/functions/mmap.html
> >
> >     The st_ctime and st_mtime fields of a file that is mapped with MAP_SHARED
> >     and PROT_WRITE shall be marked for update at some point in the interval
> >     between a write reference to the mapped region and the next call to msync() with
> >     MS_ASYNC or MS_SYNC for that portion of the file by any process. If there is
> >     no such call and if the underlying file is modified as a result of a write reference,
> >     then these fields shall be marked for update at some time after the write reference.
> 
> That says nothing about a file where the only updates are via mmap.  My
> file had grown to its final size so there were no more writes, only
> pages being dirtied via mmap.

It is specifically referring to updates via mmap!  "a write reference
to the mapped region".  This is the mmap documentation.

What you want is what the standard says we should do.  And we aren't
doing it.  Your application should perform msync(MS_ASYNC) and the
mtime should be updated.

-

  reply	other threads:[~2002-06-11  6:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-11  5:33 2.4.18 no timestamp update on modified mmapped files Keith Owens
2002-06-11  6:17 ` Andrew Morton
2002-06-11  6:29   ` Keith Owens
2002-06-11  6:49     ` Andrew Morton [this message]
2002-06-11  7:07       ` Keith Owens
2002-06-11  7:28         ` Andrew Morton
2002-06-11  9:10           ` Hugh Dickins
2002-06-11  9:33             ` Andrew Morton
2002-06-11  9:51               ` Hugh Dickins
2002-06-12  7:40             ` Alan Cox
2002-06-12  7:56               ` Andrew Morton
2002-06-12 14:52                 ` Hugh Dickins
2002-06-13  2:25                   ` jw schultz
2002-06-13  9:58                     ` Hugh Dickins
2002-06-13 10:40                       ` jw schultz
2002-06-11 18:09           ` Robert Love
2002-06-12 17:17           ` Pavel Machek
2002-06-11  6:39   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2002-06-15  5:24 Kevin Easton
2002-06-15  8:10 ` Hugh Dickins
2002-06-15  9:12   ` Kevin Easton
2002-06-15  9:23     ` Russell King
2002-06-16  4:35 Kevin Easton
2002-06-16 16:35 ` Hugh Dickins
2002-06-19 17:57 Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D059D5E.C9F9F659@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox